Attachment 304324 Details for Bug 444903 – Don't let stderr output clobber various lists

Don't let stderr output clobber various lists

policycoreutils-2.0.46-seinfoerr.patch (text/plain), 1.30 KB, created by Lubomir Rintel on 2008-05-01 17:29:27 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Lubomir Rintel

Created: 2008-05-01 17:29:27 UTC

Size: 1.30 KB

patch

obsolete

>seinfo can contain various warnings, such as "WARNING: Policy would be
>downgraded from version 23 to 22.", and getoutput merges stdout and stderr
>together, so they can't be distinguished for real data and thus they could
>clobber various lists.
>
>Prefer redirecing it to terminal to sending it to /dev/null, so that
>there's bigger chance that user notices those.
>
>Lubomir Rintel <lkundrak@v3.sk>
>
>--- policycoreutils-2.0.46/gui/polgengui.py.orig	2008-05-01 18:59:48.000000000 +0200
>+++ policycoreutils-2.0.46/gui/polgengui.py	2008-05-01 19:24:21.000000000 +0200
>@@ -210,12 +210,12 @@ class childWindow:
>         col = gtk.TreeViewColumn(_("Existing_User"), gtk.CellRendererText(), text = 0)
>         self.existing_user_treeview.append_column(col)
> 
>-        roles = commands.getoutput("/usr/bin/seinfo -r").split()[2:]
>+        roles = commands.getoutput("/usr/bin/seinfo -r 2>/dev/tty").split()[2:]
>         for i in roles:
>             iter = self.role_store.append()
>             self.role_store.set_value(iter, 0, i[:-2])
> 
>-        self.types = commands.getoutput("/usr/bin/seinfo -t").split()[2:]
>+        self.types = commands.getoutput("/usr/bin/seinfo -t 2>/dev/tty").split()[2:]
> 
>         self.transition_treeview = self.xml.get_widget("transition_treeview")
>         self.transition_store = gtk.ListStore(gobject.TYPE_STRING)

Actions: View

Attachments on bug 444903: 304322 | 304324 | 304325