Attachment 304395 Details for Bug 436260 – proposed patch

[patch] proposed patch

audacity-1.3.2-CVE-2007-6061.patch (text/plain), 1.22 KB, created by Michael Schwendt on 2008-05-02 15:54:34 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Michael Schwendt

Created: 2008-05-02 15:54:34 UTC

Size: 1.22 KB

patch

obsolete

>diff -Nur audacity-src-1.3.2-beta-orig/src/AudacityApp.cpp audacity-src-1.3.2-beta/src/AudacityApp.cpp
>--- audacity-src-1.3.2-beta-orig/src/AudacityApp.cpp	2006-10-29 01:05:26.000000000 +0200
>+++ audacity-src-1.3.2-beta/src/AudacityApp.cpp	2008-05-02 17:46:49.000000000 +0200
>@@ -821,7 +821,7 @@
>    if (tempFromPrefs != wxT("")) {
>       if (wxDirExists(tempFromPrefs))
>          temp = tempFromPrefs;
>-      else if (wxMkdir(tempFromPrefs))
>+      else if (wxMkdir(tempFromPrefs, 0755))
>          temp = tempFromPrefs;
>    }
> 
>@@ -830,10 +830,21 @@
>    if (temp==wxT("") && tempDefaultLoc != wxT("")) {
>       if (wxDirExists(tempDefaultLoc))
>          temp = tempDefaultLoc;
>-      else if (wxMkdir(tempDefaultLoc))
>+      else if (wxMkdir(tempDefaultLoc, 0755))
>          temp = tempDefaultLoc;
>    }
> 
>+   // Check temp directory ownership.
>+   struct stat tempStatBuf;
>+   if ( lstat(temp.mb_str(), &tempStatBuf) != 0 ) {
>+      temp.clear();
>+   }
>+   else {
>+      if ( geteuid() != tempStatBuf.st_uid ) {
>+         temp.clear();
>+      }
>+   }
>+
>    if (temp == wxT("")) {
>       // Failed
>       wxMessageBox(_("Audacity could not find a place to store temporary files.\nPlease enter an appropriate directory in the preferences dialog."));

Actions: View | Diff

Attachments on bug 436260: 304395