Attachment 304812 Details for Bug 445606 – fix arg_max and audit bugs

[patch] fix arg_max and audit bugs

netkit-rsh-0.17-rshdbuggy.patch (text/plain), 1.00 KB, created by Gilbert E. Detillieux on 2008-05-07 22:32:11 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Gilbert E. Detillieux

Created: 2008-05-07 22:32:11 UTC

Size: 1.00 KB

patch

obsolete

>--- netkit-rsh-0.17/rshd/rshd.c.buggy	2008-05-07 16:37:35.000000000 -0500
>+++ netkit-rsh-0.17/rshd/rshd.c	2008-05-07 17:00:00.000000000 -0500
>@@ -473,7 +473,7 @@
> 
> 	getstr(remuser, sizeof(remuser), "remuser");
> 	getstr(locuser, sizeof(locuser), "locuser");
>-	getstr(cmdbuf, sizeof(cmdbuf), "command");
>+	getstr(cmdbuf, cmdbuflen, "command");
> 	if (!strcmp(locuser, "root")) paranoid = 1;
> 
> 	hostname = findhostname((struct sockaddr *)fromp, fromlen,
>@@ -482,7 +482,7 @@
> 	setpwent();
> 	pwd = doauth(remuser, hostname, locuser);
> 	if (pwd == NULL) {
>-		if (log_audit(remuser, -1, hostname, 0) <= 0) {
>+		if (log_audit(remuser, -1, hostname, 0) > 0) {
> 			fail("Error sending audit event.\n", 
> 			     remuser, hostname, locuser, cmdbuf);
> 		}
>@@ -493,7 +493,7 @@
> 		error("Logins currently disabled.\n");
> 		exit(1);
> 	}
>-	if (log_audit(NULL, pwd->pw_uid, hostname, 1) <= 0) {
>+	if (log_audit(NULL, pwd->pw_uid, hostname, 1) > 0) {
> 		fail("Error sending audit event.\n", 
> 		     remuser, hostname, locuser, cmdbuf);
> 	}

Actions: View | Diff

Attachments on bug 445606: 304812