Attachment 304872 Details for Bug 435698 – debug patch to figure out where exactly we're corrupting the list.

[patch] debug patch to figure out where exactly we're corrupting the list.

megaraid-sas-list-corruptor-debug.patch (text/plain), 2.03 KB, created by Josef Bacik on 2008-05-08 15:39:03 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Josef Bacik

Created: 2008-05-08 15:39:03 UTC

Size: 2.03 KB

patch

obsolete

>diff -up linux-2.6.18.x86_64/drivers/scsi/megaraid/megaraid_sas.c.bz435698 linux-2.6.18.x86_64/drivers/scsi/megaraid/megaraid_sas.c
>--- linux-2.6.18.x86_64/drivers/scsi/megaraid/megaraid_sas.c.bz435698	2008-05-08 11:17:25.000000000 -0400
>+++ linux-2.6.18.x86_64/drivers/scsi/megaraid/megaraid_sas.c	2008-05-08 11:23:36.000000000 -0400
>@@ -1754,6 +1754,8 @@ static int megasas_create_frame_pool(str
> static void megasas_free_cmds(struct megasas_instance *instance)
> {
> 	int i;
>+	unsigned long flags;
>+
> 	/* First free the MFI frame pool */
> 	megasas_teardown_frame_pool(instance);
> 
>@@ -1765,7 +1767,9 @@ static void megasas_free_cmds(struct meg
> 	kfree(instance->cmd_list);
> 	instance->cmd_list = NULL;
> 
>+	spin_lock_irqsave(&instance->cmd_pool_lock, flags);
> 	INIT_LIST_HEAD(&instance->cmd_pool);
>+	spin_unlock_irqrestore(&instance->cmd_pool_lock, flags);
> }
> 
> /**
>@@ -1790,11 +1794,15 @@ static int megasas_alloc_cmds(struct meg
> {
> 	int i;
> 	int j;
>+	unsigned long flags;
> 	u32 max_cmd;
> 	struct megasas_cmd *cmd;
> 
> 	max_cmd = instance->max_fw_cmds;
> 
>+	printk(KERN_ERR "megaraid_sas: allocating cmds\n");
>+	dump_stack();
>+
> 	/*
> 	 * instance->cmd_list is an array of struct megasas_cmd pointers.
> 	 * Allocate the dynamic array first and then allocate individual
>@@ -1829,6 +1837,7 @@ static int megasas_alloc_cmds(struct meg
> 	/*
> 	 * Add all the commands to command pool (instance->cmd_pool)
> 	 */
>+	spin_lock_irqsave(&instance->cmd_pool_lock, flags);
> 	for (i = 0; i < max_cmd; i++) {
> 		cmd = instance->cmd_list[i];
> 		memset(cmd, 0, sizeof(struct megasas_cmd));
>@@ -1837,6 +1846,7 @@ static int megasas_alloc_cmds(struct meg
> 
> 		list_add_tail(&cmd->list, &instance->cmd_pool);
> 	}
>+	spin_unlock_irqrestore(&instance->cmd_pool_lock, flags);
> 
> 	/*
> 	 * Create a frame pool and assign one frame to each cmd
>@@ -2867,6 +2877,9 @@ static void megasas_detach_one(struct pc
> 	struct Scsi_Host *host;
> 	struct megasas_instance *instance;
> 
>+	printk(KERN_ERR "Tearing down megaraid_sas\n");
>+	dump_stack();
>+
> 	instance = pci_get_drvdata(pdev);
> 	host = instance->host;
>

Actions: View | Diff

Attachments on bug 435698: 304872