Attachment 304903 Details for Bug 445757 – Untested patch ending messages with newline

[patch] Untested patch ending messages with newline

0001-Add-newline-at-end-of-name_count-maxed-messages.patch (text/plain), 1.38 KB, created by Hans Ulrich Niedermann on 2008-05-08 21:16:03 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Hans Ulrich Niedermann

Created: 2008-05-08 21:16:03 UTC

Size: 1.38 KB

patch

obsolete

>From cb25e18331ecb6176d13f6ba2967fb1de4450dc2 Mon Sep 17 00:00:00 2001
>From: Hans Ulrich Niedermann <hun@n-dimensional.de>
>Date: Tue, 29 Apr 2008 21:05:22 +0200
>Subject: [PATCH] Add newline at end of "name_count maxed" messages
>
>Those messages can be issued in bursts, and that quickly fills
>the 1024 byte line buffer of printk and generates misformatted
>dmesg lines.
>
>A newline at the end of the messages should prevent that.
>
>Untested patch, as I cannot reproduce the problem which triggered
>the "name_count maxed" messages in the first place.
>
>Signed-off-by: Hans Ulrich Niedermann <hun@n-dimensional.de>
>---
> kernel/auditsc.c |    5 +++--
> 1 files changed, 3 insertions(+), 2 deletions(-)
>
>diff --git a/kernel/auditsc.c b/kernel/auditsc.c
>index 56e56ed..eb03269 100644
>--- a/kernel/auditsc.c
>+++ b/kernel/auditsc.c
>@@ -1752,13 +1752,14 @@ static int audit_inc_name_count(struct audit_context *context,
> 	if (context->name_count >= AUDIT_NAMES) {
> 		if (inode)
> 			printk(KERN_DEBUG "name_count maxed, losing inode data: "
>-			       "dev=%02x:%02x, inode=%lu",
>+			       "dev=%02x:%02x, inode=%lu\n",
> 			       MAJOR(inode->i_sb->s_dev),
> 			       MINOR(inode->i_sb->s_dev),
> 			       inode->i_ino);
> 
> 		else
>-			printk(KERN_DEBUG "name_count maxed, losing inode data");
>+			printk(KERN_DEBUG "name_count maxed, "
>+			       "losing inode data\n");
> 		return 1;
> 	}
> 	context->name_count++;
>-- 
>1.5.4.5
>

Actions: View | Diff

Attachments on bug 445757: 304903 | 492844