Attachment 304924 Details for Bug 445787 – [PATCH] DebugFS : file/directory creation error handling

[patch] [PATCH] DebugFS : file/directory creation error handling

0001-DebugFS-file-directory-creation-error-handling.patch (text/plain), 1.23 KB, created by Tao Ma on 2008-05-09 06:09:38 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Tao Ma

Created: 2008-05-09 06:09:38 UTC

Size: 1.23 KB

patch

obsolete

>From 63223a0654c2a473ae64835819b87826cb7415ee Mon Sep 17 00:00:00 2001
>From: Mathieu Desnoyers <compudj@krystal.dyndns.org>
>Date: Fri, 24 Nov 2006 13:48:19 -0500
>Subject: DebugFS : file/directory creation error handling
>
>Fix error handling of file and directory creation in DebugFS.
>
>The error path should release the file system because no _remove will be called
>for this erroneous creation.
>
>Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>
>Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
>---
> fs/debugfs/inode.c |    4 +++-
> 1 files changed, 3 insertions(+), 1 deletions(-)
>
>diff --git a/fs/debugfs/inode.c b/fs/debugfs/inode.c
>index 05d1a9c..d6c5fb5 100644
>--- a/fs/debugfs/inode.c
>+++ b/fs/debugfs/inode.c
>@@ -206,13 +206,15 @@ struct dentry *debugfs_create_file(const char *name, mode_t mode,
> 
> 	pr_debug("debugfs: creating file '%s'\n",name);
> 
>-	error = simple_pin_fs(&debug_fs_type, &debugfs_mount, &debugfs_mount_count);
>+	error = simple_pin_fs(&debug_fs_type, &debugfs_mount,
>+			      &debugfs_mount_count);
> 	if (error)
> 		goto exit;
> 
> 	error = debugfs_create_by_name(name, mode, parent, &dentry);
> 	if (error) {
> 		dentry = NULL;
>+		simple_release_fs(&debugfs_mount, &debugfs_mount_count);
> 		goto exit;
> 	}
> 
>-- 
>1.5.3.6
>

Actions: View | Diff

Attachments on bug 445787: 304923 | 304924 | 305682