Attachment 305195 Details for Bug 348961 – 0001-Catch-unknown-errors-when-parsing-the-update-metadat.patch

[patch] 0001-Catch-unknown-errors-when-parsing-the-update-metadat.patch

0001-Catch-unknown-errors-when-parsing-the-update-metadat.patch (text/plain), 1.92 KB, created by Luke Macken on 2008-05-13 03:40:29 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Luke Macken

Created: 2008-05-13 03:40:29 UTC

Size: 1.92 KB

patch

obsolete

>From aeb54b3e1fa9f24a3133fbde582181b4433536e7 Mon Sep 17 00:00:00 2001
>From: Luke Macken <lmacken@redhat.com>
>Date: Mon, 12 May 2008 23:38:16 -0400
>Subject: [PATCH] Catch unknown errors when parsing the update metadata, potentially due to corruption,
> spit out the traceback, and throw an UpdateNoticeException (rh#348961)
>
>
>diff --git a/yum/update_md.py b/yum/update_md.py
>index b5fdeda..69f5b7e 100644
>--- a/yum/update_md.py
>+++ b/yum/update_md.py
>@@ -268,16 +268,21 @@ class UpdateMetadata(object):
>         else:   # obj is a file object
>             infile = obj
> 
>-        for event, elem in iterparse(infile):
>-            if elem.tag == 'update':
>-                un = UpdateNotice(elem)
>-                if not self._notices.has_key(un['update_id']):
>-                    self._notices[un['update_id']] = un
>-                    for pkg in un['pkglist']:
>-                        for file in pkg['packages']:
>-                            self._cache['%s-%s-%s' % (file['name'],
>-                                                      file['version'],
>-                                                      file['release'])] = un
>+        try:
>+            for event, elem in iterparse(infile):
>+                if elem.tag == 'update':
>+                    un = UpdateNotice(elem)
>+                    if not self._notices.has_key(un['update_id']):
>+                        self._notices[un['update_id']] = un
>+                        for pkg in un['pkglist']:
>+                            for file in pkg['packages']:
>+                                self._cache['%s-%s-%s' % (file['name'],
>+                                                          file['version'],
>+                                                          file['release'])] = un
>+        except: # Possibly corrupted metadata
>+            import traceback
>+            traceback.print_exc()
>+            raise UpdateNoticeException
> 
>     def __str__(self):
>         ret = ''
>-- 
>1.5.4.5
>

Actions: View | Diff

Attachments on bug 348961: 305194 | 305195 | 307226