Attachment 305332 Details for Bug 446334 – Grep the all the wrong invoke in code tree and fix them.

[patch] Grep the all the wrong invoke in code tree and fix them.

timestamp.patch (text/plain), 2.92 KB, created by XINSUN on 2008-05-14 05:57:08 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: XINSUN

Created: 2008-05-14 05:57:08 UTC

Size: 2.92 KB

patch

obsolete

>Index: post.cgi
>===================================================================
>RCS file: /cvs/qa/hwcert/post.cgi,v
>retrieving revision 1.53
>diff -u -r1.53 post.cgi
>--- post.cgi	6 Feb 2008 21:31:40 -0000	1.53
>+++ post.cgi	14 May 2008 05:54:56 -0000
>@@ -761,9 +761,13 @@
>   my $gid = FetchSQLData();
>   push(@groupstoadd, $gid) if (! grep(/^$gid$/,@groupstoadd));
> 
>+  #Get the Now() timestamp as the time parameter of the func LogActivityEntry()
>+  SendSQL("SELECT ".Bugzilla::DB::Now('select'));
>+  my $timestamp = FetchOneColumn(); 
>+
>   # Force event logging to bugs_activity for metrics
>-  LogActivityEntry($id, "bug_status", 'NEW', 'CLOSED', $::userid, "now()");
>-  LogActivityEntry($id, "resolution", '', 'DUPLICATE', $::userid, "now()");
>+  LogActivityEntry($id, "bug_status", 'NEW', 'CLOSED', $::userid, $timestamp);
>+  LogActivityEntry($id, "resolution", '', 'DUPLICATE', $::userid, $timestamp);
> }
> 
> my $attachid;
>Index: attach.cgi
>===================================================================
>RCS file: /cvs/qa/hwcert/attach.cgi,v
>retrieving revision 1.30
>diff -u -r1.30 attach.cgi
>--- attach.cgi	21 Dec 2006 00:15:58 -0000	1.30
>+++ attach.cgi	14 May 2008 05:54:56 -0000
>@@ -311,11 +311,14 @@
> # FIXME later, dont pass a previously FAILED cert
> # Certify this if all PASSED
> #if (!$foundfailed && !@failures) {
>+#    #Get the Now() timestamp as the time parameter of the func LogActivityEntry()
>+#    SendSQL("SELECT ".Bugzilla::DB::Now('select'));
>+#    my $timestamp = FetchOneColumn();
> #    my $resolution = "CURRENTRELEASE";
> #    $resolution = "RAWHIDE" if $bug->{'internal_whiteboard'} eq 'Component/Peripheral';
> #    SendSQL("UPDATE bugs SET bug_status = 'CLOSED', resolution = '$resolution' WHERE bug_id = $id");
>-#    LogActivityEntry($id, "bug_status", $bug->{'bug_status'}, 'CLOSED', $userid, "now()") if $bug->{'bug_status'} ne 'NEW';
>-#    LogActivityEntry($id, "resolution", $bug->{'resolution'}, $resolution, $userid, "now()") if $bug->{'bug_status'} ne 'NEW';
>+#    LogActivityEntry($id, "bug_status", $bug->{'bug_status'}, 'CLOSED', $userid, $timestamp) if $bug->{'bug_status'} ne 'NEW';
>+#    LogActivityEntry($id, "resolution", $bug->{'resolution'}, $resolution, $userid, $timestamp) if $bug->{'bug_status'} ne 'NEW';
> #    $vars->{'autocertified'} = 1; 
> #} 
> 
>Index: Bugzilla/IssueTrackerList.pm
>===================================================================
>RCS file: /cvs/qa/hwcert/Bugzilla/IssueTrackerList.pm,v
>retrieving revision 1.1.1.1
>diff -u -r1.1.1.1 IssueTrackerList.pm
>--- Bugzilla/IssueTrackerList.pm	16 Nov 2004 16:42:36 -0000	1.1.1.1
>+++ Bugzilla/IssueTrackerList.pm	14 May 2008 05:54:56 -0000
>@@ -451,9 +451,7 @@
> =item C<-when>
> 
> Optional. A timestamp string suitable for passing to
>-C<LogActivityEntry()>.  Defaults to 'now'.  This allows users who have
>-to calculate the timestamp for many different database activites
>-(e.g., process_bugs.cgi) to use the same timestamp for them all.
>+C<LogActivityEntry()>.  
> 
> =back
>

Actions: View | Diff

Attachments on bug 446334: 305332