Attachment 306224 Details for Bug 446869 – Set the umask to 077

[patch] Set the umask to 077

0001-Change-file-mode-of-log-files-to-600.patch (text/plain), 1.96 KB, created by Martin Nagy on 2008-05-21 08:37:28 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Nagy

Created: 2008-05-21 08:37:28 UTC

Size: 1.96 KB

patch

obsolete

>From 4367b077ecec2c48484e171c457aece86ca78e64 Mon Sep 17 00:00:00 2001
>From: Martin Nagy <mnagy@redhat.com>
>Date: Tue, 20 May 2008 10:19:19 +0200
>Subject: [PATCH] Change file mode of log files to 600.
>
>446869
>---
> ipa-client/ipa-install/ipa-client-install |    3 +++
> ipa-server/ipaserver/installutils.py      |    2 ++
> 2 files changed, 5 insertions(+), 0 deletions(-)
>
>diff --git a/ipa-client/ipa-install/ipa-client-install b/ipa-client/ipa-install/ipa-client-install
>index 5355d56..54d7185 100644
>--- a/ipa-client/ipa-install/ipa-client-install
>+++ b/ipa-client/ipa-install/ipa-client-install
>@@ -63,10 +63,12 @@ def logging_setup(options):
>     if options.uninstall:
>         log_file = "/var/log/ipaclient-uninstall.log"
> 
>+    old_umask = os.umask(077)
>     logging.basicConfig(level=logging.DEBUG,
>                         format='%(asctime)s %(levelname)s %(message)s',
>                         filename=log_file,
>                         filemode='w')
>+    os.umask(old_umask)
> 
>     console = logging.StreamHandler()
>     # If the debug option is set, also log debug messages to the console
>@@ -368,6 +370,7 @@ def main():
> try:
>     import sys
> 
>+    import os
>     import krbV
>     import socket
>     import logging
>diff --git a/ipa-server/ipaserver/installutils.py b/ipa-server/ipaserver/installutils.py
>index 5eca597..ee3c1c7 100644
>--- a/ipa-server/ipaserver/installutils.py
>+++ b/ipa-server/ipaserver/installutils.py
>@@ -143,12 +143,14 @@ def port_available(port):
>     return rv
> 
> def standard_logging_setup(log_filename, debug=False):
>+    old_umask = os.umask(077)
>     # Always log everything (i.e., DEBUG) to the log
>     # file.
>     logging.basicConfig(level=logging.DEBUG,
>                         format='%(asctime)s %(levelname)s %(message)s',
>                         filename=log_filename,
>                         filemode='w')
>+    os.umask(old_umask)
> 
>     console = logging.StreamHandler()
>     # If the debug option is set, also log debug messages to the console
>-- 
>1.5.4.1
>

Actions: View | Diff

Attachments on bug 446869: 306224