Attachment 306390 Details for Bug 254195 – patch 1 - tear down rpc_clients in nlm_shutdown_hosts

[patch] patch 1 - tear down rpc_clients in nlm_shutdown_hosts

02-bz-254195-nlm-tear-down-rpc-cl.patch (text/plain), 1.22 KB, created by Jeff Layton on 2008-05-22 15:27:57 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jeff Layton

Created: 2008-05-22 15:27:57 UTC

Size: 1.22 KB

patch

obsolete

>BZ#254195: NLM: tear down RPC clients in nlm_shutdown_hosts
>
>From: Jeff Layton <jlayton@redhat.com>
>
>It's possible for a RPC to outlive the lockd daemon that created it, so
>we need to make sure that all RPC's are killed when lockd is coming down
>or the kernel can end up in a use-after-free situation. When
>nlm_shutdown_hosts is called, kill off all RPC tasks associated with the
>host. Since we need to wait until they have all gone away, we might as
>well just shut down the RPC client altogether.
>
>Signed-off-by: Jeff Layton <jlayton@redhat.com>
>---
>
> fs/lockd/host.c |    7 ++++++-
> 1 files changed, 6 insertions(+), 1 deletions(-)
>
>
>diff --git a/fs/lockd/host.c b/fs/lockd/host.c
>index 38b0e8a..4810c37 100644
>--- a/fs/lockd/host.c
>+++ b/fs/lockd/host.c
>@@ -272,8 +272,13 @@ nlm_shutdown_hosts(void)
> 	/* First, make all hosts eligible for gc */
> 	dprintk("lockd: nuking all hosts...\n");
> 	for (i = 0; i < NLM_HOST_NRHASH; i++) {
>-		for (host = nlm_hosts[i]; host; host = host->h_next)
>+		for (host = nlm_hosts[i]; host; host = host->h_next) {
> 			host->h_expires = jiffies - 1;
>+			if (host->h_rpcclnt) {
>+				rpc_shutdown_client(host->h_rpcclnt);
>+				host->h_rpcclnt = NULL;
>+			}
>+		}
> 	}
> 
> 	/* Then, perform a garbage collection pass */

Actions: View | Diff

Attachments on bug 254195: 277081 | 278361 | 280141 | 280151 | 280161 | 306390 | 306391 | 306392