Login
[x]
Log in using an account from:
Fedora Account System
Red Hat Associate
Red Hat Customer
Or login using a Red Hat Bugzilla account
Forgot Password
Login:
Hide Forgot
Create an Account
Red Hat Bugzilla – Attachment 306675 Details for
Bug 447262
CVE-2008-2292 net-snmp: buffer overflow in perl module's Perl Module __snprint_value()
[?]
New
Simple Search
Advanced Search
My Links
Browse
Requests
Reports
Current State
Search
Tabular reports
Graphical reports
Duplicates
Other Reports
User Changes
Plotly Reports
Bug Status
Bug Severity
Non-Defaults
|
Product Dashboard
Help
Page Help!
Bug Writing Guidelines
What's new
Browser Support Policy
5.0.4.rh83 Release notes
FAQ
Guides index
User guide
Web Services
Contact
Legal
This site requires JavaScript to be enabled to function correctly, please enable it.
[patch]
Nico's patch for both Perl and Python modules issues
net-snmp-5.4.1~dfsg-1_5.4.1~dfsg-7.1.patch (text/plain), 6.74 KB, created by
Tomas Hoger
on 2008-05-26 13:30:47 UTC
(
hide
)
Description:
Nico's patch for both Perl and Python modules issues
Filename:
MIME Type:
Creator:
Tomas Hoger
Created:
2008-05-26 13:30:47 UTC
Size:
6.74 KB
patch
obsolete
>diff -u net-snmp-5.4.1~dfsg/debian/changelog net-snmp-5.4.1~dfsg/debian/changelog >--- net-snmp-5.4.1~dfsg/debian/changelog >+++ net-snmp-5.4.1~dfsg/debian/changelog >@@ -1,3 +1,13 @@ >+net-snmp (5.4.1~dfsg-7.1) unstable; urgency=high >+ >+ * Non-maintainer upload by the Security Team. >+ * Fix buffer overflow in the python and perl module (__snprint_value >+ function)that can be exploited via large OCTETSTRING in an >+ attribute value pair (AVP) leading to arbitrary code >+ execution (CVE-2008-2292; Closes: #482333). >+ >+ -- Nico Golde <nion@debian.org> Sat, 24 May 2008 13:12:16 +0200 >+ > net-snmp (5.4.1~dfsg-7) unstable; urgency=low > > * Add some more Conflicts: and Replaces: magic to allow moving >only in patch2: >unchanged: >--- net-snmp-5.4.1~dfsg.orig/debian/patches/48-CVE-2008-2292.patch >+++ net-snmp-5.4.1~dfsg/debian/patches/48-CVE-2008-2292.patch >@@ -0,0 +1,170 @@ >+diff -Nurad net-snmp-5.4.1~dfsg.orig/perl/SNMP/SNMP.xs net-snmp-5.4.1~dfsg/perl/SNMP/SNMP.xs >+--- net-snmp-5.4.1~dfsg.orig/perl/SNMP/SNMP.xs 2008-05-24 11:53:07.000000000 +0200 >++++ net-snmp-5.4.1~dfsg/perl/SNMP/SNMP.xs 2008-05-24 12:48:16.000000000 +0200 >+@@ -470,14 +470,15 @@ >+ if (flag == USE_ENUMS) { >+ for(ep = tp->enums; ep; ep = ep->next) { >+ if (ep->value == *var->val.integer) { >+- strcpy(buf, ep->label); >++ strncpy(buf, ep->label, buf_len); >++ buf[buf_len -1] = 0; >+ len = strlen(buf); >+ break; >+ } >+ } >+ } >+ if (!len) { >+- sprintf(buf,"%ld", *var->val.integer); >++ snprintf(buf, buf_len, "%ld", *var->val.integer); >+ len = strlen(buf); >+ } >+ break; >+@@ -486,19 +487,21 @@ >+ case ASN_COUNTER: >+ case ASN_TIMETICKS: >+ case ASN_UINTEGER: >+- sprintf(buf,"%lu", (unsigned long) *var->val.integer); >++ snprintf(buf, buf_len, "%lu", (unsigned long) *var->val.integer); >+ len = strlen(buf); >+ break; >+ >+ case ASN_OCTET_STR: >+ case ASN_OPAQUE: >+- memcpy(buf, (char*)var->val.string, var->val_len); >++ if (len > buf_len) >++ len = buf_len; >++ memcpy(buf, (char*)var->val.string, len); >+ len = var->val_len; >+ break; >+ >+ case ASN_IPADDRESS: >+ ip = (u_char*)var->val.string; >+- sprintf(buf, "%d.%d.%d.%d", ip[0], ip[1], ip[2], ip[3]); >++ snprintf(buf, buf_len, "%d.%d.%d.%d", ip[0], ip[1], ip[2], ip[3]); >+ len = strlen(buf); >+ break; >+ >+@@ -512,13 +515,13 @@ >+ break; >+ >+ case SNMP_ENDOFMIBVIEW: >+- sprintf(buf,"%s", "ENDOFMIBVIEW"); >++ snprintf(buf, buf_len, "%s", "ENDOFMIBVIEW"); >+ break; >+ case SNMP_NOSUCHOBJECT: >+- sprintf(buf,"%s", "NOSUCHOBJECT"); >++ snprintf(buf, buf_len, "%s", "NOSUCHOBJECT"); >+ break; >+ case SNMP_NOSUCHINSTANCE: >+- sprintf(buf,"%s", "NOSUCHINSTANCE"); >++ snprintf(buf, buf_len, "%s", "NOSUCHINSTANCE"); >+ break; >+ >+ case ASN_COUNTER64: >+@@ -538,18 +541,18 @@ >+ #endif >+ >+ case ASN_BIT_STR: >+- snprint_bitstring(buf, sizeof(buf), var, NULL, NULL, NULL); >++ snprint_bitstring(buf, buf_len, var, NULL, NULL, NULL); >+ len = strlen(buf); >+ break; >+ #ifdef NETSNMP_WITH_OPAQUE_SPECIAL_TYPES >+ case ASN_OPAQUE_FLOAT: >+ if (var->val.floatVal) >+- sprintf(buf,"%f", *var->val.floatVal); >++ snprintf(buf, buf_len, "%f", *var->val.floatVal); >+ break; >+ >+ case ASN_OPAQUE_DOUBLE: >+ if (var->val.doubleVal) >+- sprintf(buf,"%f", *var->val.doubleVal); >++ snprintf(buf, buf_len, "%f", *var->val.doubleVal); >+ break; >+ #endif >+ >+diff -Nurad net-snmp-5.4.1~dfsg.orig/python/netsnmp/client_intf.c net-snmp-5.4.1~dfsg/python/netsnmp/client_intf.c >+--- net-snmp-5.4.1~dfsg.orig/python/netsnmp/client_intf.c 2008-05-24 11:53:07.000000000 +0200 >++++ net-snmp-5.4.1~dfsg/python/netsnmp/client_intf.c 2008-05-24 12:30:51.000000000 +0200 >+@@ -330,14 +330,15 @@ >+ if (flag == USE_ENUMS) { >+ for(ep = tp->enums; ep; ep = ep->next) { >+ if (ep->value == *var->val.integer) { >+- strcpy(buf, ep->label); >++ strncpy(buf, ep->label, buf_len); >++ buf[buf_len -1] = 0; >+ len = STRLEN(buf); >+ break; >+ } >+ } >+ } >+ if (!len) { >+- sprintf(buf,"%ld", *var->val.integer); >++ snprintf(buf, buf_len, "%ld", *var->val.integer); >+ len = STRLEN(buf); >+ } >+ break; >+@@ -346,19 +347,21 @@ >+ case ASN_COUNTER: >+ case ASN_TIMETICKS: >+ case ASN_UINTEGER: >+- sprintf(buf,"%lu", (unsigned long) *var->val.integer); >++ snprintf(buf, buf_len, "%lu", (unsigned long) *var->val.integer); >+ len = STRLEN(buf); >+ break; >+ >+ case ASN_OCTET_STR: >+ case ASN_OPAQUE: >+- memcpy(buf, (char*)var->val.string, var->val_len); >++ if(len > buf_len) >++ len = buf_len; >++ memcpy(buf, (char*)var->val.string, len); >+ len = var->val_len; >+ break; >+ >+ case ASN_IPADDRESS: >+ ip = (u_char*)var->val.string; >+- sprintf(buf, "%d.%d.%d.%d", ip[0], ip[1], ip[2], ip[3]); >++ snprintf(buf, buf_len, "%d.%d.%d.%d", ip[0], ip[1], ip[2], ip[3]); >+ len = STRLEN(buf); >+ break; >+ >+@@ -372,13 +375,13 @@ >+ break; >+ >+ case SNMP_ENDOFMIBVIEW: >+- sprintf(buf,"%s", "ENDOFMIBVIEW"); >++ snprintf(buf, buf_len, "%s", "ENDOFMIBVIEW"); >+ break; >+ case SNMP_NOSUCHOBJECT: >+- sprintf(buf,"%s", "NOSUCHOBJECT"); >++ snprintf(buf, buf_len, "%s", "NOSUCHOBJECT"); >+ break; >+ case SNMP_NOSUCHINSTANCE: >+- sprintf(buf,"%s", "NOSUCHINSTANCE"); >++ snprintf(buf, buf_len, "%s", "NOSUCHINSTANCE"); >+ break; >+ >+ case ASN_COUNTER64: >+@@ -398,18 +401,18 @@ >+ #endif >+ >+ case ASN_BIT_STR: >+- snprint_bitstring(buf, sizeof(buf), var, NULL, NULL, NULL); >++ snprint_bitstring(buf, buf_len, var, NULL, NULL, NULL); >+ len = STRLEN(buf); >+ break; >+ #ifdef OPAQUE_SPECIAL_TYPES >+ case ASN_OPAQUE_FLOAT: >+ if (var->val.floatVal) >+- sprintf(buf,"%f", *var->val.floatVal); >++ snprintf(buf, buf_len, "%f", *var->val.floatVal); >+ break; >+ >+ case ASN_OPAQUE_DOUBLE: >+ if (var->val.doubleVal) >+- sprintf(buf,"%f", *var->val.doubleVal); >++ snprintf(buf, buf_len, "%f", *var->val.doubleVal); >+ break; >+ #endif >+
<b>You cannot view the attachment while viewing its details because your browser does not support IFRAMEs. <a href="attachment.cgi?id=306675">View the attachment on a separate page</a>.</b>
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
Attachments on
bug 447262
: 306675