Attachment 306747 Details for Bug 448485 – Patch to teach pam_mount to use getgrouplist

[patch] Patch to teach pam_mount to use getgrouplist

pam_mount-debug.patch (text/plain), 1.18 KB, created by Thomas Sailer on 2008-05-27 08:43:28 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Thomas Sailer

Created: 2008-05-27 08:43:28 UTC

Size: 1.18 KB

patch

obsolete

>--- src/rdconf1.c.debug	2007-12-06 23:05:08.000000000 +0100
>+++ src/rdconf1.c	2008-05-27 10:16:52.000000000 +0200
>@@ -450,14 +450,40 @@
> {
> 	struct group *gent;
> 	const char **wp;
>+	struct passwd *pw;
>+	gid_t *gidlist = NULL;
>+	int nrgids = 0, gididx;
> 
> 	if ((gent = getgrnam(grp)) == NULL) {
> 		w4rn("getgrnam(\"%s\") failed: %s\n", grp, strerror(errno));
> 		return false;
> 	}
> 
>+	pw = getpwnam(user);
>+	if (!pw) {
>+		w4rn("getpwnam(\"%s\") failed: %s\n", user, strerror(errno));
>+	} else {
>+		if (getgrouplist(user, pw->pw_gid, NULL, &nrgids) < 0) {
>+			gidlist = (gid_t *)malloc(nrgids * sizeof(gidlist[0]));
>+			if (getgrouplist(user, pw->pw_gid, gidlist, &nrgids) < 0) {
>+				nrgids = 0;
>+				w4rn("getgrouplist(\"%s\",%d) failed: %s\n", user, pw->pw_gid, strerror(errno));
>+			}
>+		}
>+		bool ok = false;
>+		for (gididx = 0; gididx < nrgids; gididx++)
>+			if (gidlist[gididx] == gent->gr_gid) {
>+				ok = true;
>+				break;
>+			}
>+		free(gidlist);
>+		if (ok)
>+			return true;
>+	}
>+
> 	wp = const_cast(const char **, gent->gr_mem);
> 	while (wp != NULL && *wp != NULL) {
>+		w4rn("check user \"%s\" is group member of \"%s\": \"%s\"\n", user, grp, *wp);
> 		if (strcmp(*wp, user) == 0)
> 			return true;
> 		++wp;

Actions: View | Diff

Attachments on bug 448485: 306747