Attachment 306982 Details for Bug 448774 – Patch to display release notes publicly for private bugs (v1)

[patch] Patch to display release notes publicly for private bugs (v1)

public_release_notes.patch (text/plain), 2.87 KB, created by David Lawrence on 2008-05-28 20:24:02 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: David Lawrence

Created: 2008-05-28 20:24:02 UTC

Size: 2.87 KB

patch

obsolete

>Index: Bugzilla/Bug.pm
>===================================================================
>RCS file: /cvs/qa/rh_bugzilla_3/Bugzilla/Bug.pm,v
>retrieving revision 1.40
>diff -u -r1.40 Bug.pm
>--- Bugzilla/Bug.pm	28 May 2008 16:53:32 -0000	1.40
>+++ Bugzilla/Bug.pm	28 May 2008 20:19:44 -0000
>@@ -3585,11 +3585,28 @@
> # are not authorized to see the bug. Display an error and stop execution.
> # The error the user sees depends on whether or not they are logged in
> # (i.e. $user->id contains the user's positive integer ID).
>+ 
>+ # REDHAT EXTENSION START 448774
>+ my $bug = Bugzilla::Bug->new($id);
>+ my $public_header;
>+ my $public_body;
>+ if ($bug->{'cf_release_notes'}) {
>+ $public_header = "Release Notes:";
>+ $public_body = $bug->{'cf_release_notes'};
>+ }
>+
> if ($user->id) {
>- ThrowUserError("bug_access_denied", {'bug_id' => $id});
>+ ThrowUserError("bug_access_denied", 
>+ {'bug_id' => $id, 
>+ 'public_header' => $public_header, 
>+ 'public_body' => $public_body});
> } else {
>- ThrowUserError("bug_access_query", {'bug_id' => $id});
>+ ThrowUserError("bug_access_query", 
>+ {'bug_id' => $id, 
>+ 'public_header' => $public_header, 
>+ 'public_body' => $public_body});
> }
>+ # REDHAT EXTENSION END 448774
> }
> 
> # Validate and return a hash of dependencies
>Index: template/en/default/global/user-error.html.tmpl
>===================================================================
>RCS file: /cvs/qa/rh_bugzilla_3/template/en/default/global/user-error.html.tmpl,v
>retrieving revision 1.27
>diff -u -r1.27 user-error.html.tmpl
>--- template/en/default/global/user-error.html.tmpl	14 May 2008 03:28:19 -0000	1.27
>+++ template/en/default/global/user-error.html.tmpl	28 May 2008 20:19:44 -0000
>@@ -217,6 +217,14 @@
> [% title = "Access Denied" %]
> [% admindocslinks = {'groups.html' => 'Group Security'} %]
> You are not authorized to access [% terms.bug %] #[% bug_id FILTER html %].
>+ [%# REDHAT EXTENSION START 448774 %]
>+ [% IF public_header && public_body %]
>+ 
>+ [% public_header FILTER html %] 
>+ [% public_body FILTER html %]
>+ 
>+ [% END %]
>+ [%# REDHAT EXTENSION END 448774 %]
> 
> [% ELSIF error == "bug_access_query" %]
> [% title = "Access Denied" %]
>@@ -226,6 +234,14 @@
> first <a href="show_bug.cgi?id=
> [% bug_id FILTER url_quote %]&amp;GoAheadAndLogIn=1">log
> in to an account</a> with the appropriate permissions.
>+ [%# REDHAT EXTENSION START 448774 %]
>+ [% IF public_header && public_body %]
>+ 
>+ [% public_header FILTER html %] 
>+ [% public_body FILTER html %]
>+ 
>+ [% END %]
>+ [%# REDHAT EXTENSION END 448774 %]
> 
> [% ELSIF error == "buglist_parameters_required" %]
> [% title = "Parameters Required" %]

Flags:

nelhawar: review+
dkl: review? (kbaker)

Actions: View | Diff

Attachments on bug 448774: 306982 | 307137 | 307159