Attachment 307045 Details for Bug 430452 – Proposed patch

[patch] Proposed patch

kernel-hangs-when-hitting-sysrq-w-repeatedly.patch (text/plain), 1.14 KB, created by Ivan Vecera on 2008-05-29 12:44:07 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Ivan Vecera

Created: 2008-05-29 12:44:07 UTC

Size: 1.14 KB

patch

obsolete

>diff --git a/drivers/char/sysrq.c b/drivers/char/sysrq.c
>index 011d65d..c7aeafa 100644
>--- a/drivers/char/sysrq.c
>+++ b/drivers/char/sysrq.c
>@@ -185,19 +185,32 @@ static struct sysrq_key_op sysrq_showmem_op = {
> 	.action_msg	= "Show Memory",
> };
> 
>-static spinlock_t show_lock = SPIN_LOCK_UNLOCKED;
>+static DEFINE_SPINLOCK(show_lock);
>+
> static void showacpu(void *info)
> {
>-	spin_lock(&show_lock);
>-	printk("CPU%d:\n", smp_processor_id());
>+	unsigned long flags;
>+
>+	spin_lock_irqsave(&show_lock, flags);
>+	printk(KERN_INFO "CPU%d:\n", smp_processor_id());
> 	show_stack(NULL, NULL);
>-	spin_unlock(&show_lock);
>+	spin_unlock_irqrestore(&show_lock, flags);
>+}
>+
>+static void sysrq_show_othercpus(void *dummy)
>+{
>+	smp_call_function(showacpu, NULL, 0, 0);
> }
>+
>+static DECLARE_WORK(sysrq_showcpus, sysrq_show_othercpus, NULL);
>+
> static void sysrq_handle_showcpus(int key, struct pt_regs *pt_regs,
>-				  struct tty_struct *tty) {
>+				  struct tty_struct *tty)
>+{
> 	showacpu(NULL);
>-	smp_call_function(showacpu, NULL, 0, 0);
>+	schedule_work(&sysrq_showcpus);
> }
>+
> static struct sysrq_key_op sysrq_showcpus_op = {
> 	handler:	sysrq_handle_showcpus,
> 	help_msg:	"shoWcpus",

Actions: View | Diff

Attachments on bug 430452: 307045 | 310406