Attachment 307125 Details for Bug 448792 – Make IPA -> AD pass sync work again

[patch] Make IPA -> AD pass sync work again

0001-Let-DS-encode-the-password-this-will-allow-IPA-A.patch (text/plain), 1.70 KB, created by Simo Sorce on 2008-05-29 19:23:23 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Simo Sorce

Created: 2008-05-29 19:23:23 UTC

Size: 1.70 KB

patch

obsolete

>>From 6cabb2d5fc6e5fb914c91498e0f4cd00b372b5b9 Mon Sep 17 00:00:00 2001
>From: Simo Sorce <ssorce@redhat.com>
>Date: Thu, 29 May 2008 14:00:48 -0400
>Subject: [PATCH] Let DS encode the password, this will allow IPA -> AD password
> synchronization to work again.
>
>---
> .../ipa-pwd-extop/ipa_pwd_extop.c                  |   14 ++++----------
> 1 files changed, 4 insertions(+), 10 deletions(-)
>
>diff --git a/ipa-server/ipa-slapi-plugins/ipa-pwd-extop/ipa_pwd_extop.c b/ipa-server/ipa-slapi-plugins/ipa-pwd-extop/ipa_pwd_extop.c
>index f07bbbf..21e50db 100644
>--- a/ipa-server/ipa-slapi-plugins/ipa-pwd-extop/ipa_pwd_extop.c
>+++ b/ipa-server/ipa-slapi-plugins/ipa-pwd-extop/ipa_pwd_extop.c
>@@ -1631,7 +1631,6 @@ static int ipapwd_SetPassword(struct ipapwd_data *data)
> 	struct ntlm_keys ntlm;
> 	int ntlm_flags = 0;
> 	Slapi_Value *sambaSamAccount;
>-	char *userpwd;
> 
> 	krberr = krb5_init_context(&krbctx);
> 	if (krberr) {
>@@ -1701,15 +1700,10 @@ static int ipapwd_SetPassword(struct ipapwd_data *data)
> 		free(password);
> 	}
> 
>-	/* use the default configured encoding */
>-	userpwd = slapi_encode(data->password, NULL);
>-	if (!userpwd) {
>-		slapi_log_error(SLAPI_LOG_FATAL, "ipa_pwd_extop", "failed to make userPassword hash\n");
>-		ret = LDAP_OPERATIONS_ERROR;
>-		goto free_and_return;
>-	}
>-
>-	slapi_mods_add_string(smods, LDAP_MOD_REPLACE, "userPassword", userpwd);
>+	/* let DS encode the password itself, this allows also other plugins to
>+	 * intercept it to perform operations like synchronization with Active
>+	 * Directory domains through the replication plugin */
>+	slapi_mods_add_string(smods, LDAP_MOD_REPLACE, "userPassword", data->password);
> 
> 	/* set password history */
> 	pwvals = ipapwd_setPasswordHistory(smods, data);
>-- 
>1.5.4.1
>

Actions: View | Diff

Attachments on bug 448792: 307125