Attachment 307285 Details for Bug 244576 – firewire: don't panic on invalid AR request buffer

[patch] firewire: don't panic on invalid AR request buffer

725-firewire-dont-panic-on-invalid-ar-request-buffer.patch (text/plain), 1.02 KB, created by Stefan Richter on 2008-05-31 17:38:05 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Stefan Richter

Created: 2008-05-31 17:38:05 UTC

Size: 1.02 KB

patch

obsolete

>Date: Sat, 31 May 2008 19:01:26 +0200 (CEST)
>From: Stefan Richter <stefanr@s5r6.in-berlin.de>
>Subject: firewire: don't panic on invalid AR request buffer
>
>BUG() at this place is wrong.  (Unless if the low level driver would
>already do higher-level input validation of incoming request headers.)
>
>Invalid incoming requests or bugs in the controller which corrupt the
>AR-req buffer needlessly crashed the box because this is run in tasklet
>context.
>
>Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
>---
> drivers/firewire/fw-transaction.c |    3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
>Index: linux/drivers/firewire/fw-transaction.c
>===================================================================
>--- linux.orig/drivers/firewire/fw-transaction.c
>+++ linux/drivers/firewire/fw-transaction.c
>@@ -575,7 +575,8 @@ allocate_request(struct fw_packet *p)
> 		break;
> 
> 	default:
>-		BUG();
>+		fw_error("ERROR - corrupt request received - %08x %08x %08x\n",
>+			 p->header[0], p->header[1], p->header[2]);
> 		return NULL;
> 	}
>

Actions: View | Diff

Attachments on bug 244576: 307285 | 307286 | 307296 | 309401 | 309402