Attachment 307296 Details for Bug 244576 – firewire: fw-ohci: clear LinkControl register when enabling the chip

[patch] firewire: fw-ohci: clear LinkControl register when enabling the chip

727-firewire-fw-ohci-clear-linkcontrol-register-when-enabling-the-chip.patch (text/plain), 1.16 KB, created by Stefan Richter on 2008-05-31 23:12:02 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Stefan Richter

Created: 2008-05-31 23:12:02 UTC

Size: 1.16 KB

patch

obsolete

>Date: Sun, 1 Jun 2008 01:08:22 +0200 (CEST)
>From: Stefan Richter <stefanr@s5r6.in-berlin.de>
>Subject: firewire: fw-ohci: clear LinkControl register when enabling the chip
>
>We want the rcvPhyPkt bit in LinkControl off before we start using the
>chip.  However, the spec says that the reset value of it is undefined.
>Hence switch it (and all other bits while we are at it) explicitly off.
>
>https://bugzilla.redhat.com/show_bug.cgi?id=244576#c48 shows that for
>example the nForce2 integrated FireWire controller seems to have it on
>by default.
>
>Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
>---
> drivers/firewire/fw-ohci.c |    1 +
> 1 file changed, 1 insertion(+)
>
>Index: linux/drivers/firewire/fw-ohci.c
>===================================================================
>--- linux.orig/drivers/firewire/fw-ohci.c
>+++ linux/drivers/firewire/fw-ohci.c
>@@ -1473,6 +1473,7 @@ static int ohci_enable(struct fw_card *c
> 	reg_write(ohci, OHCI1394_HCControlClear,
> 		  OHCI1394_HCControl_noByteSwapData);
> 
>+	reg_write(ohci, OHCI1394_LinkControlClear, ~0);
> 	reg_write(ohci, OHCI1394_LinkControlSet,
> 		  OHCI1394_LinkControl_rcvSelfID |
> 		  OHCI1394_LinkControl_cycleTimerEnable |

Actions: View | Diff

Attachments on bug 244576: 307285 | 307286 | 307296 | 309401 | 309402