Attachment 308644 Details for Bug 449252 – fw-cdev-log-request-response.patch

[patch] fw-cdev-log-request-response.patch

fw-cdev-log-request-response.patch (text/plain), 2.84 KB, created by Stefan Richter on 2008-06-08 09:54:05 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Stefan Richter

Created: 2008-06-08 09:54:05 UTC

Size: 2.84 KB

patch

obsolete

>Adds debug messages for FW_CDEV_IOC_SEND_REQUEST ioctl()s and for
>corresponding fw_cdev_event_response events.  Activate with
># echo 1 > /sys/module/firewire_core/parameters/debug
>Switch off again with
># echo 0 > /sys/module/firewire_core/parameters/debug
>---
> drivers/firewire/fw-cdev.c |   46 +++++++++++++++++++++++++++++++++++++
> 1 file changed, 46 insertions(+)
>
>Index: linux/drivers/firewire/fw-cdev.c
>===================================================================
>--- linux.orig/drivers/firewire/fw-cdev.c
>+++ linux/drivers/firewire/fw-cdev.c
>@@ -362,6 +362,40 @@ release_transaction(struct client *clien
> 	fw_cancel_transaction(client->device->card, &response->transaction);
> }
> 
>+static int param_debug;
>+module_param_named(debug, param_debug, int, 0644);
>+MODULE_PARM_DESC(debug, "Verbose logging (default = 0, requests/responses = 1)");
>+
>+static const char *rcodes[] = {
>+	[0x00] = "complete",		[0x01] = "?",
>+	[0x02] = "?",			[0x03] = "?",
>+	[0x04] = "conflict error",	[0x05] = "data error",
>+	[0x06] = "type error",		[0x07] = "address error",
>+	[0x08] = "?",			[0x09] = "?",
>+	[0x0a] = "?",			[0x0b] = "?",
>+	[0x0c] = "?",			[0x0d] = "?",
>+	[0x0e] = "?",			[0x0f] = "?",
>+	[0x10] = "send error",		[0x11] = "cancelled",
>+	[0x12] = "busy",		[0x13] = "generation",
>+	[0x14] = "no ack",		[0x15] = "?",
>+	[0x16] = "?",			[0x17] = "?",
>+	[0x18] = "?",			[0x19] = "?",
>+	[0x1a] = "?",			[0x1b] = "?",
>+	[0x1c] = "?",			[0x1d] = "?",
>+	[0x1e] = "?",			[0x1f] = "?",
>+};
>+
>+static const char *tcodes[] = {
>+	[0x0] = "QW req",		[0x1] = "BW req",
>+	[0x2] = "W resp",		[0x3] = "-reserved-",
>+	[0x4] = "QR req",		[0x5] = "BR req",
>+	[0x6] = "QR resp",		[0x7] = "BR resp",
>+	[0x8] = "cycle start",		[0x9] = "Lk req",
>+	[0xa] = "async stream packet",	[0xb] = "Lk resp",
>+	[0xc] = "-reserved-",		[0xd] = "-reserved-",
>+	[0xe] = "link internal",	[0xf] = "-reserved-",
>+};
>+
> static void
> complete_transaction(struct fw_card *card, int rcode,
> 		     void *payload, size_t length, void *data)
>@@ -385,6 +419,12 @@ complete_transaction(struct fw_card *car
> 	queue_event(client, &response->event,
> 		    &response->response, sizeof(response->response),
> 		    response->response.data, response->response.length);
>+
>+	if (param_debug & 1)
>+		printk(KERN_DEBUG KBUILD_MODNAME
>+		       ": got response %llx: %s\n",
>+		       (unsigned long long)response->response.closure,
>+		       rcodes[rcode & 0x1f]);
> }
> 
> static int ioctl_send_request(struct client *client, void *buffer)
>@@ -393,6 +433,12 @@ static int ioctl_send_request(struct cli
> 	struct fw_cdev_send_request *request = buffer;
> 	struct response *response;
> 
>+	if (param_debug & 1)
>+		printk(KERN_DEBUG KBUILD_MODNAME
>+		       ": send request %llx: %s\n",
>+		       (unsigned long long)request->closure,
>+		       tcodes[request->tcode & 0xf]);
>+
> 	/* What is the biggest size we'll accept, really? */
> 	if (request->length > 4096)
> 		return -EINVAL;

Actions: View | Diff

Attachments on bug 449252: 308227 | 308644 | 308959 | 309400 | 336233 | 394655