Attachment 308743 Details for Bug 443241 – CVS Diffs

[patch] CVS Diffs

diffs.txt (text/plain), 1.36 KB, created by Nathan Kinder on 2008-06-09 18:48:42 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Nathan Kinder

Created: 2008-06-09 18:48:42 UTC

Size: 1.36 KB

patch

obsolete

>Index: memberof.c
>===================================================================
>RCS file: /cvs/dirsec/ldapserver/ldap/servers/plugins/memberof/memberof.c,v
>retrieving revision 1.7
>diff -u -5 -t -r1.7 memberof.c
>--- memberof.c	21 Apr 2008 17:45:15 -0000	1.7
>+++ memberof.c	9 Jun 2008 18:46:37 -0000
>@@ -2186,27 +2186,25 @@
> }
> 
> /* memberof_fix_memberof_callback()
>  * Add initial and/or fix up broken group list in entry
>  *
>- * 1. Make sure direct membership groups are in the entry
>- * 2. Add all groups that current group list allows through nested membership
>- * 3. Trim groups that have no relationship to entry
>+ * 1. Remove all present memberOf values
>+ * 2. Add direct group membership memberOf values
>+ * 3. Add indirect group membership memberOf values
>  */
> int memberof_fix_memberof_callback(Slapi_Entry *e, void *callback_data)
> {
>         int rc = 0;
>         char *dn = slapi_entry_get_dn(e);
>         memberof_add_groups data = {dn, dn};
> 
>-        /* step 1. and step 2. */
>+        /* step 1 */
>+        slapi_entry_attr_delete(e, MEMBEROF_ATTR);
>+
>+        /* step 2 and 3 */
>         rc = memberof_call_foreach_dn(0, dn, MEMBEROF_GROUP_ATTR, 
>                 memberof_add_groups_search_callback, &data);
>-        if(0 == rc)
>-        {
>-                /* step 3. */
>-                rc = memberof_test_membership_callback(e, 0);
>-        }
> 
>         return rc;
> }
>

Actions: View | Diff

Attachments on bug 443241: 308743