Attachment 309643 Details for Bug 451157 – patch 2/2 - locking re-ordered continued from bug 440121

patch 2/2 - locking re-ordered continued from bug 440121

linux-2.6-misc-ttys1-loses-interrupt-and-stops-transmitting.patch (text/plain), 1.04 KB, created by Andrius Benokraitis on 2008-06-17 17:40:21 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Andrius Benokraitis

Created: 2008-06-17 17:40:21 UTC

Size: 1.04 KB

patch

obsolete

>diff -Naur linux-2.6.18.x86_64.orig/drivers/serial/8250.c linux-2.6.18.x86_64/drivers/serial/8250.c
>--- linux-2.6.18.x86_64.orig/drivers/serial/8250.c	2008-06-10 18:24:12.000000000 +0000
>+++ linux-2.6.18.x86_64/drivers/serial/8250.c	2008-06-10 19:48:24.000000000 +0000
>@@ -1762,7 +1762,11 @@
> 	 */
> 	serial_outp(up, UART_LCR, UART_LCR_WLEN8);
> 
>-	spin_lock_irqsave(&up->port.lock, flags);
>+	if (is_real_interrupt(up->port.irq)) {
>+		spin_lock_irqsave(&irq_lists[up->port.irq].lock, flags);
>+		spin_lock(&up->port.lock);
>+	} else
>+		spin_lock_irqsave(&up->port.lock, flags);
> 	if (up->port.flags & UPF_FOURPORT) {
> 		if (!is_real_interrupt(up->port.irq))
> 			up->port.mctrl |= TIOCM_OUT1;
>@@ -1794,7 +1798,11 @@
> 		up->bugs &= ~UART_BUG_TXEN;
> 	}
> 
>-	spin_unlock_irqrestore(&up->port.lock, flags);
>+	if (is_real_interrupt(up->port.irq)) {
>+		spin_unlock(&up->port.lock);
>+		spin_unlock_irqrestore(&irq_lists[up->port.irq].lock, flags);
>+	} else
>+		spin_unlock_irqrestore(&up->port.lock, flags);
> 
> 	/*
> 	 * Finally, enable interrupts.  Note: Modem status interrupts

Actions: View

Attachments on bug 451157: 309643