Attachment 310175 Details for Bug 370931 – [dvgrab patch] fix segfault when timecodes are bad (from Patrick Mansfield)

[patch] [dvgrab patch] fix segfault when timecodes are bad (from Patrick Mansfield)

dvgrab-fix-segfault-when-timecodes-are-bad.patch (text/plain), 1.91 KB, created by Stefan Richter on 2008-06-24 19:26:41 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Stefan Richter

Created: 2008-06-24 19:26:41 UTC

Size: 1.91 KB

patch

obsolete

>Date: 2008-04-13 18:42
>From: Patrick Mansfield <patman@ar...>
>Subject: fix segfault when timecodes are bad
>
>Hi -
>
>I am also hitting bug 1865787 "dvgrab-3.x -autosplit segfaults', this:
>
>http://sourceforge.net/tracker/index.php?func=detail&aid=1865787&group_id=14103&atid=114103
>
>Large timecode values are causing a stack overflow in DVgrab::sendCaptureStatus,
>the printf precision for integers specifies the minimum number of digits,
>not the maximum, so the tc_str can be longer than 32 bytes.
>
>I don't know WHY the timecodes are so large, but at least it doesn't
>segfault with this patch.
>
>With the fix (or while debugging), I am seeing status lines like this:
>
>"again-2003.12.24_09-06-53.avi": 36.91 MiB 322 frames timecode 00:07:56.14 date 2003.12.24 09:07:04
>"again-2003.12.24_09-08-20.avi": 74.57 MiB 651 frames timecode 167058900:-1319513512:-1291087864.163713312 date 2008.04.13 11:23:17
>"again-2004.01.14_11-32-20.avi": 10.02 MiB 87 frames timecode 00:00:03.15 date 2004.01.14 11:32:23
>
>Without the fix, we segfault before the second line above can be output.
>
>I have a test file if someone wants it, but it is 200Mb in size.
>
>The strings should fit into 47 and 77 bytes respectively, but the fix
>allows for some extra space and uses 64 and 128 bytes for the strings in
>DVgrab::sendCaptureStatus (even though it is the timecode that was causing
>the segfault, we should be safe and increase the size of both strings).
>
>Index: dvgrab.cc
>===================================================================
>RCS file: /cvsroot/kino/dvgrab/dvgrab.cc,v
>retrieving revision 1.61
>diff -u -r1.61 dvgrab.cc
>--- dvgrab.cc 27 Feb 2008 05:09:48 -0000 1.61
>+++ dvgrab.cc 13 Apr 2008 18:27:11 -0000
>@@ -779,7 +779,7 @@
> 
> void DVgrab::sendCaptureStatus( const char *name, float size, int frames, TimeCode *tc, struct tm *rd, bool newline )
> {
>-	char tc_str[32], rd_str[32];
>+	char tc_str[64], rd_str[128];
> 
> 	if ( tc )
> 		sprintf( tc_str, "%2.2d:%2.2d:%2.2d.%2.2d",

Actions: View | Diff

Attachments on bug 370931: 251301 | 310175 | 310176