Attachment 310658 Details for Bug 453574 – [NET] front: Fix crashes when xenstore watches fire multiple times.

[patch] [NET] front: Fix crashes when xenstore watches fire multiple times.

xen-3.1-testing-13021-79315be2c9b9 (text/plain), 988 bytes, created by Alex Zeffertt on 2008-07-01 12:59:10 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Alex Zeffertt

Created: 2008-07-01 12:59:10 UTC

Size: 988 bytes

patch

obsolete

>diff -ur a/drivers/xen/netfront/netfront.c b/drivers/xen/netfront/netfront.c
>--- a/drivers/xen/netfront/netfront.c	2008-06-27 11:11:38.000000000 -0400
>+++ b/drivers/xen/netfront/netfront.c	2008-06-27 11:58:28.000000000 -0400
>@@ -544,6 +544,8 @@
> 		break;
> 
> 	case XenbusStateInitWait:
>+		if (dev->state != XenbusStateInitialising)
>+			break;
> 		if (network_connect(netdev) != 0) {
> 			netif_free(np);
> 			break;
>@@ -553,6 +555,8 @@
> 		break;
> 
> 	case XenbusStateClosing:
>+		if (dev->state == XenbusStateClosed)
>+			break;
>  		xenbus_frontend_closed(dev);
> 		break;
> 	}
>diff -ur a/drivers/xen/xenbus/xenbus_probe.c b/drivers/xen/xenbus/xenbus_probe.c
>--- a/drivers/xen/xenbus/xenbus_probe.c	2008-06-27 11:11:38.000000000 -0400
>+++ b/drivers/xen/xenbus/xenbus_probe.c	2008-06-27 11:59:01.000000000 -0400
>@@ -597,6 +597,8 @@
> 	if (!xendev)
> 		return -ENOMEM;
> 
>+	xendev->state = XenbusStateInitialising;
>+
> 	/* Copy the strings into the extra space. */
> 
> 	tmpstring = (char *)(xendev + 1);

Actions: View | Diff

Attachments on bug 453574: 310658