Attachment 310935 Details for Bug 445674 – dio: fix cache invalidation after sync writes

[patch] dio: fix cache invalidation after sync writes

dio-fix-cache-invalidation-after-sync-writes.patch (text/plain), 1.20 KB, created by Jeff Moyer on 2008-07-03 15:49:38 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jeff Moyer

Created: 2008-07-03 15:49:38 UTC

Size: 1.20 KB

patch

obsolete

>--- a/mm/filemap.c.orig	2008-05-22 11:43:12.000000000 -0400
>+++ b/mm/filemap.c	2008-05-22 12:06:55.000000000 -0400
>@@ -2643,21 +2643,17 @@ generic_file_direct_IO(int rw, struct ki
> 	}
> 
> 	retval = mapping->a_ops->direct_IO(rw, iocb, iov, offset, nr_segs);
>-	if (retval)
>-		goto out;
> 
> 	/* 
> 	 * Finally, try again to invalidate clean pages which might have been
>-	 * faulted in by get_user_pages() if the source of the write was an
>-	 * mmap()ed region of the file we're writing.  That's a pretty crazy
>-	 * thing to do, so we don't support it 100%.  If this invalidation
>-	 * fails and we have -EIOCBQUEUED we ignore the failure.
>+	 * cached by non-direct readahead, or faulted in by get_user_pages()
>+	 * if the source of the write was an mmap'ed region of the file
>+	 * we're writing.  Either one is a pretty crazy thing to do,
>+	 * so we don't support it 100%.  If this invalidation
>+	 * fails, tough, the write still worked...
> 	 */
> 	if (rw == WRITE && mapping->nrpages) {
>-		int err = invalidate_inode_pages2_range(mapping,
>-					      offset >> PAGE_CACHE_SHIFT, end);
>-		if (err && retval >= 0)
>-			retval = err;
>+		invalidate_inode_pages2_range(mapping, offset >> PAGE_CACHE_SHIFT, end);
> 	}
> out:
> 	return retval;

Actions: View | Diff

Attachments on bug 445674: 310935