Attachment 310964 Details for Bug 453222 – Be more careful when removing groups

[patch] Be more careful when removing groups

freeipa-57-delgroup.patch (text/plain), 1.33 KB, created by Rob Crittenden on 2008-07-03 21:11:57 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Rob Crittenden

Created: 2008-07-03 21:11:57 UTC

Size: 1.33 KB

patch

obsolete

>From b613cee63bb5bde2d3871c5bfd8b891cfed14129 Mon Sep 17 00:00:00 2001
>From: Rob Crittenden <rcrit@ipa.greyoak.com>
>Date: Thu, 3 Jul 2008 17:06:09 -0400
>Subject: [PATCH] Be more exacting when deleting a group.
>
>453222
>---
> ipa-admintools/ipa-delgroup |   14 +++++++++-----
> 1 files changed, 9 insertions(+), 5 deletions(-)
>
>diff --git a/ipa-admintools/ipa-delgroup b/ipa-admintools/ipa-delgroup
>index 7ae62d2..3add9ac 100644
>--- a/ipa-admintools/ipa-delgroup
>+++ b/ipa-admintools/ipa-delgroup
>@@ -26,6 +26,7 @@ try:
>     import ipa.ipautil as ipautil
>     import errno
>     import socket
>+    import ldap
> 
>     import xmlrpclib
>     import kerberos
>@@ -65,15 +66,18 @@ def main():
> 
>     counter = groups[0]
>     groups = groups[1:] 
>+    to_delete = None
> 
>-    if counter == 0:
>+    for i in range(counter):
>+        dn_list = ldap.explode_dn(groups[i].dn.lower())
>+        if "cn=%s" % args[1].lower() in dn_list:
>+            to_delete = groups[i]
>+
>+    if to_delete is None:
>         print "Group '%s' not found." % args[1]
>         return 2
>-    if counter != 1:
>-        print "An exact group match was not found. Found %d groups" % counter
>-        return 2
> 
>-    ret = client.delete_group(groups[0].dn)
>+    ret = client.delete_group(to_delete.dn)
>     if (ret == "Success"):
>         print args[1] + " successfully deleted"
>     else:
>-- 
>1.5.4.1
>

Actions: View | Diff

Attachments on bug 453222: 310964