Attachment 311123 Details for Bug 451399 – patch: don't call sleeping function from invalid context

[patch] patch: don't call sleeping function from invalid context

patch-451399 (text/plain), 1.06 KB, created by Zhang Rui on 2008-07-07 03:21:00 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Zhang Rui

Created: 2008-07-07 03:21:00 UTC

Size: 1.06 KB

patch

obsolete

>From: Zhang Rui <rui.zhang@intel.com>
>SUbject: libata: don't call sleeping function from invalid context
>
>acpi_evaluate_integer is a sleeping function,
>and it can not be called with spin_lock_irqsave.
>
>Sighed-off-by: Zhang Rui <rui.zhang@intel.com>
>---
> drivers/ata/libata-acpi.c |    3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
>Index: linux-2.6/drivers/ata/libata-acpi.c
>===================================================================
>--- linux-2.6.orig/drivers/ata/libata-acpi.c	2007-05-04 10:57:08.000000000 +0800
>+++ linux-2.6/drivers/ata/libata-acpi.c	2008-07-07 11:15:02.000000000 +0800
>@@ -195,6 +195,8 @@
> 		/* This device does not support hotplug */
> 		return;
> 
>+	status = acpi_evaluate_integer(handle, "_STA", NULL, &sta);
>+
> 	spin_lock_irqsave(ap->lock, flags);
> 
> 	switch (event) {
>@@ -202,7 +204,6 @@
> 	case ACPI_NOTIFY_DEVICE_CHECK:
> 		ata_ehi_push_desc(ehi, "ACPI event");
> 
>-		status = acpi_evaluate_integer(handle, "_STA", NULL, &sta);
> 		if (ACPI_FAILURE(status)) {
> 			ata_port_printk(ap, KERN_ERR,
> 				"acpi: failed to determine bay status (0x%x)\n",

Actions: View | Diff

Attachments on bug 451399: 311123 | 312909 | 312910 | 312911 | 312912 | 312913 | 312914 | 313011 | 313445 | 316628