Attachment 311325 Details for Bug 454559 – DOGTAG 1.0: pki-common-1.0.0-ocsp-null-get.patch

DOGTAG 1.0: pki-common-1.0.0-ocsp-null-get.patch

pki-common-1.0.0-ocsp-null-get.patch (text/plain), 1.70 KB, created by Matthew Harmsen on 2008-07-08 23:40:54 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Matthew Harmsen

Created: 2008-07-08 23:40:54 UTC

Size: 1.70 KB

patch

obsolete

>Index: base/common/src/com/netscape/cms/servlet/ocsp/OCSPServlet.java
>===================================================================
>--- base/common/src/com/netscape/cms/servlet/ocsp/OCSPServlet.java	(revision 64)
>+++ base/common/src/com/netscape/cms/servlet/ocsp/OCSPServlet.java	(working copy)
>@@ -171,7 +171,10 @@
>               is = new ByteArrayInputStream(reqbuf);
>             } else {
>               // GET method
>-              if (pathInfo == null) {
>+              if ( (pathInfo == null)              ||
>+                   (pathInfo.equals( "" ) )        ||
>+                   (pathInfo.substring(1) == null) ||
>+                   (pathInfo.substring(1).equals( "" ) ) ) {
>                   throw new Exception("OCSPServlet: OCSP request not provided in GET method");
>               }
>               is = new ByteArrayInputStream(
>@@ -186,7 +189,17 @@
>                 OCSPRequest.Template reqTemplate = 
>                     new OCSPRequest.Template();
> 
>+                if ( (is == null) ||
>+                     (is.toString().equals( "" ) ) ) {
>+                    throw new Exception( "OCSPServlet: OCSP request is "
>+                                       + "empty or malformed");
>+                }
>                 ocspReq = (OCSPRequest) reqTemplate.decode(is);
>+                if ( (ocspReq == null) ||
>+                     (ocspReq.toString().equals( "" ) ) ) {
>+                    throw new Exception( "OCSPServlet: Decoded OCSP request "
>+                                       + "is empty or malformed");
>+                }
>                 response = ((IOCSPService) mAuthority).validate(ocspReq);
>             } catch (Exception e) {;
>                 CMS.debug("OCSPServlet: " + e.toString());

Actions: View

Attachments on bug 454559: 311325 | 311332