Attachment 311443 Details for Bug 454459 – patch for the rest of NEEDINFO_* cleanup

[patch] patch for the rest of NEEDINFO_* cleanup

patch.diff (text/plain), 1.49 KB, created by Noura El hawary on 2008-07-10 05:03:29 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Noura El hawary

Created: 2008-07-10 05:03:29 UTC

Size: 1.49 KB

patch

obsolete

>Index: redhat/needinfo_status_cleanup.pl
>===================================================================
>RCS file: /cvs/qa/rh_bugzilla_3/redhat/needinfo_status_cleanup.pl,v
>retrieving revision 1.2
>diff -p -u -r1.2 needinfo_status_cleanup.pl
>--- redhat/needinfo_status_cleanup.pl	9 Jul 2008 21:40:53 -0000	1.2
>+++ redhat/needinfo_status_cleanup.pl	10 Jul 2008 04:57:56 -0000
>@@ -193,6 +193,9 @@ my $select_other_status_sth
> $select_other_status_sth->execute($needinfo_reporter_status);
> while ( my @row = $select_other_status_sth->fetchrow_array() ) {
>     my ($bug_id, $reporter_id) = @row;
>+
>+    $needinfo_flag = 'needinfo?';
>+
>     my $select_bug_flag = $dbh->prepare( "
>         SELECT  id 
>           FROM  flags 
>@@ -220,7 +223,6 @@ while ( my @row = $select_other_status_s
>         my $reporter_login = $select_reporter_login->fetchrow;
>         $needinfo_flag .= "($reporter_login)" if $reporter_login;
> 
>-
>         log_activity( $bug_id, $flag_field_id, $needinfo_flag, '' );
>         $changes_check{needinfo_reporter_status_bugs_no_flag}++;
>     }
>@@ -253,7 +255,13 @@ sub change_to_prev_status {
>         SELECT  removed 
>           FROM  bugs_activity 
>          WHERE  bug_id = ?
>-           AND  fieldid = ? 
>+           AND  fieldid = ?
>+           AND  removed 
>+            IN  (SELECT  value 
>+                   FROM  bug_status 
>+                  WHERE  isactive=1 
>+                    AND  is_open=1 
>+                    AND  value != 'NEEDINFO')
>       ORDER BY  bug_when 
>     DESC LIMIT  1" );
>

Flags:

dkl: review+

Actions: View | Diff

Attachments on bug 454459: 311372 | 311443