Attachment 311689 Details for Bug 455230 – patch for this problem from the upstream kernel

[patch] patch for this problem from the upstream kernel

v4l-ioctl-debugging-fix.patch (text/plain), 1.60 KB, created by Arnd Bergmann on 2008-07-14 11:39:24 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Arnd Bergmann

Created: 2008-07-14 11:39:24 UTC

Size: 1.60 KB

patch

obsolete

>backport from
>
>| commit 072cb5fb8397500e5c028fb2bb0e61e812d2dc1e
>| Author: Hans Verkuil <hverkuil@xs4all.nl>
>| Date:   Sun Jun 22 08:55:09 2008 -0300
>| 
>|     V4L/DVB (8103): videodev: fix/improve ioctl debugging
>|     
>|     Various ioctl debugging fixes and improvements:
>|     
>|     - use %x rather than %d for control IDs and bitmask fields
>|     - make two arrays const
>|     - show the whole control array for the ext_ctrl ioctls
>|     - print pix_fmt for V4L2_BUF_TYPE_VIDEO_OUTPUT
>|     - show full type name rather than an integer
>|     - fix CROPCAP debugging
>|     - fix G/S_TUNER debugging
>|     - show error code in case of an error
>|     - other small cleanups
>|     
>|     Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl>
>|     Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org>
>| 
>diff --git a/drivers/media/video/videodev.c b/drivers/media/video/videodev.c
>index 9075b6d..56044a0 100644
>--- a/drivers/media/video/videodev.c
>+++ b/drivers/media/video/videodev.c
>@@ -17,15 +17,19 @@
>  */
> 
> #define dbgarg(cmd, fmt, arg...) \
>-		if (vfd->debug & V4L2_DEBUG_IOCTL_ARG) {		\
>+		do {							\
>+		    if (vfd->debug & V4L2_DEBUG_IOCTL_ARG) {		\
> 			printk(KERN_DEBUG "%s: ",  vfd->name);		\
> 			v4l_printk_ioctl(cmd);				\
> 			printk(" " fmt,  ## arg);			\
>-		}
>+		    }							\
>+		} while (0)
> 
> #define dbgarg2(fmt, arg...) \
>-		if (vfd->debug & V4L2_DEBUG_IOCTL_ARG)			\
>-			printk(KERN_DEBUG "%s: " fmt, vfd->name, ## arg);
>+		do {							\
>+		    if (vfd->debug & V4L2_DEBUG_IOCTL_ARG)		\
>+			printk(KERN_DEBUG "%s: " fmt, vfd->name, ## arg);\
>+		} while (0)
> 
> #include <linux/module.h>
> #include <linux/types.h>

Actions: View | Diff

Attachments on bug 455230: 311686 | 311689