Login
[x]
Log in using an account from:
Fedora Account System
Red Hat Associate
Red Hat Customer
Or login using a Red Hat Bugzilla account
Forgot Password
Login:
Hide Forgot
Create an Account
Red Hat Bugzilla – Attachment 311847 Details for
Bug 455447
FEAT: RHEL 5.3: (1/2) Increase deep idle state residency on idle platforms using Nehalem class processors
[?]
New
Simple Search
Advanced Search
My Links
Browse
Requests
Reports
Current State
Search
Tabular reports
Graphical reports
Duplicates
Other Reports
User Changes
Plotly Reports
Bug Status
Bug Severity
Non-Defaults
|
Product Dashboard
Help
Page Help!
Bug Writing Guidelines
What's new
Browser Support Policy
5.0.4.rh83 Release notes
FAQ
Guides index
User guide
Web Services
Contact
Legal
This site requires JavaScript to be enabled to function correctly, please enable it.
Patch for this bug
c1_idle_fix_2.patch (text/plain), 1.53 KB, created by
John Villalovos
on 2008-07-15 15:35:04 UTC
(
hide
)
Description:
Patch for this bug
Filename:
MIME Type:
Creator:
John Villalovos
Created:
2008-07-15 15:35:04 UTC
Size:
1.53 KB
patch
obsolete
> >ACPI processor_idle uses saved idle routine for C1 state, which on recent CPUs >will be mwait_idle. > >mwait_idle in older kernels has a > while (!need_resched) >loop, instead of > if (!need_resched) >in upstream kernels. > >This results in older kernels, the CPU will stay in C1 for extended >periods of time (I saw > 500 mS), unless something is scheduled to run >on that CPU, once ACPI decides on entering C1. > >One fix is to change that while loop to if as in upstream. Below is alternate >fix which is simpler and safer. With this, we come out of C1 on next tick >(1 mS or 4 mS) and ACPI reevaluates the C-states while going to idle. > >Signed-off-by: Venkatesh Pallipadi <venkatesh.pallipadi@intel.com> > >diff -purN linux-2.6.18.x86_64.org/drivers/acpi/processor_idle.c linux-2.6.18.x86_64/drivers/acpi/processor_idle.c >--- linux-2.6.18.x86_64.org/drivers/acpi/processor_idle.c 2006-09-19 20:42:06.000000000 -0700 >+++ linux-2.6.18.x86_64/drivers/acpi/processor_idle.c 2008-05-28 08:37:20.000000000 -0700 >@@ -247,10 +247,7 @@ static void acpi_processor_idle(void) > > cx = pr->power.state; > if (!cx) { >- if (pm_idle_save) >- pm_idle_save(); >- else >- acpi_safe_halt(); >+ acpi_safe_halt(); > return; > } > >@@ -340,13 +337,8 @@ static void acpi_processor_idle(void) > case ACPI_STATE_C1: > /* > * Invoke C1. >- * Use the appropriate idle routine, the one that would >- * be used without acpi C-states. > */ >- if (pm_idle_save) >- pm_idle_save(); >- else >- acpi_safe_halt(); >+ acpi_safe_halt(); > > /* > * TBD: Can't get time duration while in C1, as resumes
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Raw
Actions:
View
Attachments on
bug 455447
: 311847