Attachment 311848 Details for Bug 455449 – Patch for this bug

[patch] Patch for this bug

broadcast_timer_el5.patch (text/plain), 2.20 KB, created by John Villalovos on 2008-07-15 15:37:07 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: John Villalovos

Created: 2008-07-15 15:37:07 UTC

Size: 2.20 KB

patch

obsolete

>
>Optimize the C3 local APIC timer broadcast logic by sending a IPI broadcast
>instead of serial IPI to all the CPUs.
>
>Signed-off-by: Venkatesh Pallipadi <venkatesh.pallipadi@intel.com>
>Signed-off-by: Suresh Siddha <suresh.b.siddha@intel.com>
>
>diff -purN linux-2.6.18.x86_64/arch/i386/kernel/apic.c linux-2.6.18.x86_64.new/arch/i386/kernel/apic.c
>--- linux-2.6.18.x86_64/arch/i386/kernel/apic.c	2008-06-24 18:02:22.000000000 -0700
>+++ linux-2.6.18.x86_64.new/arch/i386/kernel/apic.c	2008-07-01 22:41:31.000000000 -0700
>@@ -36,6 +36,7 @@
> #include <asm/hpet.h>
> #include <asm/i8253.h>
> #include <asm/nmi.h>
>+#include <asm/ipi.h>
> 
> #include <mach_apic.h>
> #include <mach_apicdef.h>
>@@ -1254,20 +1255,26 @@ static void up_apic_timer_interrupt_call
> 
> void smp_send_timer_broadcast_ipi(struct pt_regs *regs)
> {
>+#ifdef CONFIG_SMP
> 	cpumask_t mask;
> 
>+	if (cpus_equal(cpu_online_map, timer_bcast_ipi)) {
>+		__send_IPI_shortcut(APIC_DEST_ALLINC, LOCAL_TIMER_VECTOR);
>+		return;
>+	}
> 	cpus_and(mask, cpu_online_map, timer_bcast_ipi);
> 	if (!cpus_empty(mask)) {
>-#ifdef CONFIG_SMP
> 		send_IPI_mask(mask, LOCAL_TIMER_VECTOR);
>+	}
> #else
>+	if (!cpus_empty(timer_bcast_ipi)) {
> 		/*
> 		 * We can directly call the apic timer interrupt handler
> 		 * in UP case. Minus all irq related functions
> 		 */
> 		up_apic_timer_interrupt_call(regs);
>-#endif
> 	}
>+#endif
> }
> 
> int setup_profiling_timer(unsigned int multiplier)
>diff -purN linux-2.6.18.x86_64/arch/x86_64/kernel/apic.c linux-2.6.18.x86_64.new/arch/x86_64/kernel/apic.c
>--- linux-2.6.18.x86_64/arch/x86_64/kernel/apic.c	2008-06-30 23:25:59.000000000 -0700
>+++ linux-2.6.18.x86_64.new/arch/x86_64/kernel/apic.c	2008-07-01 18:43:28.000000000 -0700
>@@ -36,6 +36,7 @@
> #include <asm/idle.h>
> #include <asm/proto.h>
> #include <asm/timex.h>
>+#include <asm/ipi.h>
> 
> int apic_verbosity;
> int apic_runs_main_timer;
>@@ -897,6 +898,12 @@ void smp_send_timer_broadcast_ipi(void)
> {
> 	cpumask_t mask;
> 
>+	if (cpus_equal(cpu_online_map, timer_interrupt_broadcast_ipi_mask)) {
>+		__send_IPI_shortcut(APIC_DEST_ALLINC, LOCAL_TIMER_VECTOR,
>+					APIC_DEST_LOGICAL);
>+		return;
>+	}
>+
> 	cpus_and(mask, cpu_online_map, timer_interrupt_broadcast_ipi_mask);
> 	if (!cpus_empty(mask)) {
> 		send_IPI_mask(mask, LOCAL_TIMER_VECTOR);

Actions: View | Diff

Attachments on bug 455449: 311848