Login
[x]
Log in using an account from:
Fedora Account System
Red Hat Associate
Red Hat Customer
Or login using a Red Hat Bugzilla account
Forgot Password
Login:
Hide Forgot
Create an Account
Red Hat Bugzilla – Attachment 311900 Details for
Bug 452974
[24][FOCUS] plist_add/del crash with 2.6.24.7-65ibmrt2.4 kernel
[?]
New
Simple Search
Advanced Search
My Links
Browse
Requests
Reports
Current State
Search
Tabular reports
Graphical reports
Duplicates
Other Reports
User Changes
Plotly Reports
Bug Status
Bug Severity
Non-Defaults
|
Product Dashboard
Help
Page Help!
Bug Writing Guidelines
What's new
Browser Support Policy
5.0.4.rh83 Release notes
FAQ
Guides index
User guide
Web Services
Contact
Legal
This site requires JavaScript to be enabled to function correctly, please enable it.
rwlock: be more conservative in locking reader_lock_count
conservative_lock_count.patch (text/plain), 5.51 KB, created by
IBM Bug Proxy
on 2008-07-16 00:30:39 UTC
(
hide
)
Description:
rwlock: be more conservative in locking reader_lock_count
Filename:
MIME Type:
Creator:
IBM Bug Proxy
Created:
2008-07-16 00:30:39 UTC
Size:
5.51 KB
patch
obsolete
>From rostedt@goodmis.org Mon Jul 14 23:05:15 2008 >Return-Path: <rostedt@goodmis.org> >Received: from imap.linux.ibm.com ([unix socket]) by imap.linux.ibm.com > (Cyrus v2.3.7-Invoca-RPM-2.3.7-7) with LMTPA; Mon, 14 Jul 2008 23:05:15 > -0400 >X-Sieve: CMU Sieve 2.3 >Received: by imap.linux.ibm.com (Postfix, from userid 101) id DA9961910017; > Mon, 14 Jul 2008 23:05:15 -0400 (EDT) >X-Spam-TestScore: none >X-Spam-TokenSummary: Bayes not run. >X-Spam-Checker-Version: SpamAssassin 3.1.7 (2006-10-05) on > imap.linux.ibm.com >X-Spam-Level: >X-Spam-Status: No, score=0.0 required=5.0 tests=none autolearn=disabled > version=3.1.7 >X-Spam-Relay-Country: XX XX >Received: from smtp.linux.ibm.com (smtp.linux.ibm.com [9.26.4.197]) by > imap.linux.ibm.com (Postfix) with ESMTP id 55AEE191002A for > <johnstul@imap.linux.ibm.com>; Mon, 14 Jul 2008 23:05:12 -0400 (EDT) >Received: from localhost (localhost.localdomain [127.0.0.1]) by > smtp.linux.ibm.com (Postfix) with ESMTP id E5ADBC040 for > <johnstul@linux.ibm.com>; Mon, 14 Jul 2008 23:05:11 -0400 (EDT) >X-Virus-Scanned: amavisd-new at linux.ibm.com >Received: from BLDGATE.BOULDER.IBM.COM (bldgate.boulder.ibm.com > [9.17.210.138]) by smtp.linux.ibm.com (Postfix) with ESMTP id A1391C03F for > <johnstul@linux.ibm.com>; Mon, 14 Jul 2008 23:05:11 -0400 (EDT) >Received: by BLDGATE.BOULDER.IBM.COM (IBM VM SMTP Level 530) via spool > with SMTP id 0711 ; Mon, 14 Jul 2008 21:05:10 MDT >Received: by bldgate.vnet.ibm.com (xagent2 6.0.1) via xagsmtp3 with spool > id 4506 for johnstul@linux.vnet.ibm.com; Mon, 14 Jul 2008 21:05:10 -0600 > (MDT) >Received: from d03relay03.boulder.ibm.com [9.17.195.228] by > BLDGATE.BOULDER.IBM.COM (IBM VM SMTP Level 530) via TCP with ESMTP ; Mon, > 14 Jul 2008 21:05:10 MDT >Received: from d03av05.boulder.ibm.com (d03av05.boulder.ibm.com > [9.17.195.85]) by d03relay03.boulder.ibm.com (8.13.8/8.13.8/NCO v9.0) with > ESMTP id m6F35B0K132994 for <johnstul@us.ibm.com>; Mon, 14 Jul 2008 > 21:05:11 -0600 >Received: from d03av05.boulder.ibm.com (loopback [127.0.0.1]) by > d03av05.boulder.ibm.com (8.13.1/8.13.3) with ESMTP id m6F35AIj001388 for > <johnstul@us.ibm.com>; Mon, 14 Jul 2008 21:05:10 -0600 >Received: from d03atspamtest02.boulder.ibm.com (d03atspamtest02 > [9.17.195.254]) by d03av05.boulder.ibm.com (8.13.1/8.12.11) with ESMTP id > m6F35AlT001385 for <johnstul@us.ibm.com>; Mon, 14 Jul 2008 21:05:10 -0600 >Received: from e2.ny.us.ibm.com (e2.pok.ibm.com [9.56.232.142]) by > d03atspamtest02.boulder.ibm.com (8.12.11.20060308/8.12.11) with ESMTP id > m6F359ma028232 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 > verify=OK) for <johnstul@us.ibm.com>; Mon, 14 Jul 2008 21:05:10 -0600 >Received: from hrndva-omtalb.mail.rr.com (hrndva-omtalb.mail.rr.com > [71.74.56.125]) by e2.ny.us.ibm.com (8.13.8/8.13.8) with ESMTP id > m6F356Td001159 for <johnstul@us.ibm.com>; Mon, 14 Jul 2008 23:05:06 -0400 >Received: from gandalf ([74.74.65.243]) by hrndva-omta02.mail.rr.com with > ESMTP id <20080715025322.RQHN2298.hrndva-omta02.mail.rr.com@gandalf> for > <johnstul@us.ibm.com>; Tue, 15 Jul 2008 02:53:22 +0000 >Date: Mon, 14 Jul 2008 22:53:21 -0400 (EDT) >From: Steven Rostedt <rostedt@goodmis.org> >X-X-Sender: rostedt@gandalf.stny.rr.com >To: john stultz <johnstul@us.ibm.com> >Subject: [PATCH] rwlock: be more conservative in locking reader_lock_count >Message-ID: <Pine.LNX.4.58.0807142252230.4530@gandalf.stny.rr.com> >MIME-Version: 1.0 >Content-Type: TEXT/PLAIN; charset=US-ASCII >X-Xagent-From: rostedt@goodmis.org >X-Xagent-To: johnstul@linux.vnet.ibm.com >X-Xagent-Gateway: bldgate.vnet.ibm.com (XAGENTU2 at BLDGATE) >X-Evolution-Source: imap://johnstul@imap.linux.ibm.com/ >Content-Transfer-Encoding: 8bit > >John can you try this patch and see if it fixes the warning you get. It >may be that the warning is an actual bug. > >-- Steve > > >Signed-off-by: Steven Rostedt <srostedt@redhat.com> >--- > kernel/rtmutex.c | 16 ++++++++-------- > 1 file changed, 8 insertions(+), 8 deletions(-) > >Index: linux-2.6.24.7-rt-73/kernel/rtmutex.c >=================================================================== >--- linux-2.6.24.7-rt-73.orig/kernel/rtmutex.c 2008-07-14 22:27:13.000000000 -0400 >+++ linux-2.6.24.7-rt-73/kernel/rtmutex.c 2008-07-14 22:30:54.000000000 -0400 >@@ -1137,16 +1137,13 @@ rt_rwlock_update_owner(struct rw_mutex * > if (own == RT_RW_READER) > return; > >- /* >- * We don't need to grab the pi_lock to look at the reader list >- * since we hold the rwm wait_lock. We only care about the pointer >- * to this lock, and we own the wait_lock, so that pointer >- * can't be changed. >- */ >+ spin_lock(&own->pi_lock); > for (i = own->reader_lock_count - 1; i >= 0; i--) { > if (own->owned_read_locks[i].lock == rwm) > break; > } >+ spin_unlock(&own->pi_lock); >+ > /* It is possible the owner didn't add it yet */ > if (i < 0) > return; >@@ -1453,7 +1450,6 @@ __rt_read_fasttrylock(struct rw_mutex *r > current->owned_read_locks[reader_count].count = 1; > } else > WARN_ON_ONCE(1); >- spin_unlock(¤t->pi_lock); > /* > * If this task is no longer the sole owner of the lock > * or someone is blocking, then we need to add the task >@@ -1463,12 +1459,16 @@ __rt_read_fasttrylock(struct rw_mutex *r > struct rt_mutex *mutex = &rwm->mutex; > struct reader_lock_struct *rls; > >+ /* preserve lock order, we only need wait_lock now */ >+ spin_unlock(¤t->pi_lock); >+ > spin_lock(&mutex->wait_lock); > rls = ¤t->owned_read_locks[reader_count]; > if (!rls->list.prev || list_empty(&rls->list)) > list_add(&rls->list, &rwm->readers); > spin_unlock(&mutex->wait_lock); >- } >+ } else >+ spin_unlock(¤t->pi_lock); > local_irq_restore(flags); > return 1; > }
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Raw
Actions:
View
Attachments on
bug 452974
: 311900