Attachment 312158 Details for Bug 450802 – Patch Improve:

[patch] Patch Improve:

postdate1.patch (text/plain), 1.90 KB, created by XINSUN on 2008-07-18 17:43:47 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: XINSUN

Created: 2008-07-18 17:43:47 UTC

Size: 1.90 KB

patch

obsolete

>Index: process.cgi
>===================================================================
>RCS file: /cvs/qa/hwcert/process.cgi,v
>retrieving revision 1.29
>diff -u -r1.29 process.cgi
>--- process.cgi	14 May 2008 05:18:33 -0000	1.29
>+++ process.cgi	8 Jul 2008 09:12:05 -0000
>@@ -156,9 +156,9 @@
>                if (!defined($date)) {
>                   ThrowUserError("illegal_date", { date => $new_postdate });
>                }
>-               #Validate if the PostDate is the past date.
>+               #Validate if the PostDate is the past date or today.
>                trick_taint($new_postdate);
>-               SendSQL("SELECT (TO_DAYS('$new_postdate') < TO_DAYS(NOW()))");
>+               SendSQL("SELECT (TO_DAYS('$new_postdate') <= TO_DAYS(NOW()))");
>                my $ispast_date = FetchOneColumn();
>                if ($ispast_date == 1 ) {
>                   ThrowUserError("date_is_not_in_future");
>Index: template/en/default/global/user-error.html.tmpl
>===================================================================
>RCS file: /cvs/qa/hwcert/template/en/default/global/user-error.html.tmpl,v
>retrieving revision 1.15
>diff -u -r1.15 user-error.html.tmpl
>--- template/en/default/global/user-error.html.tmpl	16 Jul 2008 10:21:52 -0000	1.15
>+++ template/en/default/global/user-error.html.tmpl	18 Jul 2008 17:38:55 -0000
>@@ -156,10 +156,9 @@
>     are committed: [% both FILTER none %]. This would create a circular
>     dependency, which is not allowed.
> 
>-  [% ELSIF error == "date_already_past" %]
>-    [% title = "Date already past" %]
>-    The posting date: '<tt>[% date FILTER html %]</tt>' is in the past. Please set a posting date 
>-    in the future. 
>+  [% ELSIF error == "date_is_not_in_future" %]
>+    [% title = "Date is not in the future" %]
>+    The selected posting date is not in the future. Press back to select another date.
> 
>   [% ELSIF error == "dependency_loop_single" %]
>     [% title = "Dependency Loop Detected" %]

Actions: View | Diff

Attachments on bug 450802: 311242 | 312158