Attachment 312167 Details for Bug 453711 – patch -- properly initialize fattrs in nfs3_proc_getacl and nfs3_proc_setacls

[patch] patch -- properly initialize fattrs in nfs3_proc_getacl and nfs3_proc_setacls

0001-BZ-453711-NFS-missing-nfs_fattr_init-in-nfs3_proc_.patch (text/plain), 1.25 KB, created by Jeff Layton on 2008-07-18 19:02:33 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jeff Layton

Created: 2008-07-18 19:02:33 UTC

Size: 1.25 KB

patch

obsolete

>From 8c533ef29733029d16b72b5d7690614db5c2c0a1 Mon Sep 17 00:00:00 2001
>From: Jeff Layton <jlayton@redhat.com>
>Date: Fri, 18 Jul 2008 14:56:44 -0400
>Subject: [PATCH] BZ#453711: NFS: missing nfs_fattr_init in nfs3_proc_getacl and nfs3_proc_setacls
>
>The fattrs used in the NFSv3 getacl/setacl calls are not being properly
>initialized.
>
>Signed-off-by: Jeff Layton <jlayton@redhat.com>
>---
> fs/nfs/nfs3acl.c |    2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
>diff --git a/fs/nfs/nfs3acl.c b/fs/nfs/nfs3acl.c
>index 9b73625..efb2724 100644
>--- a/fs/nfs/nfs3acl.c
>+++ b/fs/nfs/nfs3acl.c
>@@ -225,6 +225,7 @@ struct posix_acl *nfs3_proc_getacl(struct inode *inode, int type)
> 
> 	dprintk("NFS call getacl\n");
> 	msg.rpc_proc = &server->client_acl->cl_procinfo[ACLPROC3_GETACL];
>+	nfs_fattr_init(&fattr);
> 	status = rpc_call_sync(server->client_acl, &msg, 0);
> 	dprintk("NFS reply getacl: %d\n", status);
> 
>@@ -318,6 +319,7 @@ static int nfs3_proc_setacls(struct inode *inode, struct posix_acl *acl,
> 
> 	dprintk("NFS call setacl\n");
> 	msg.rpc_proc = &server->client_acl->cl_procinfo[ACLPROC3_SETACL];
>+	nfs_fattr_init(&fattr);
> 	status = rpc_call_sync(server->client_acl, &msg, 0);
> 	spin_lock(&inode->i_lock);
> 	NFS_I(inode)->cache_validity |= NFS_INO_INVALID_ACCESS;
>-- 
>1.5.5.1
>

Actions: View | Diff

Attachments on bug 453711: 310761 | 310763 | 312145 | 312154 | 312167