Attachment 312253 Details for Bug 456078 – Patch increasing timeout in wait_drive_not_busy

[patch] Patch increasing timeout in wait_drive_not_busy

TEAC-wait_drive_not_busy-timeouts.patch (text/plain), 1.25 KB, created by Bryn M. Reeves on 2008-07-21 12:37:20 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Bryn M. Reeves

Created: 2008-07-21 12:37:20 UTC

Size: 1.25 KB

patch

obsolete

>commit f54feafa6d47d0aa1a96adefdc763b708b02f94f
>Author: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
>Date:   Fri Jun 20 20:53:33 2008 +0200
>
>    ide: increase timeout in wait_drive_not_busy()
>    
>    Some ATAPI devices take longer than the current max timeout value to
>    become ready (i.e. TEAC DV-W28ECW takes 6 ms) so increase the timeout
>    value to 10 ms.
>    
>    This fixes kernel.org bugzilla bug #10887:
>    http://bugzilla.kernel.org/show_bug.cgi?id=10887
>    
>    Reported-by: Masanari Iida <standby24x7@gmail.com>
>    Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
>
>diff --git a/drivers/ide/ide-taskfile.c b/drivers/ide/ide-taskfile.c
>index 0c908ca..ab545ff 100644
>--- a/drivers/ide/ide-taskfile.c
>+++ b/drivers/ide/ide-taskfile.c
>@@ -225,10 +225,10 @@ static u8 wait_drive_not_busy(ide_drive_t *drive)
> 	u8 stat;
> 
> 	/*
>-	 * Last sector was transfered, wait until drive is ready.
>-	 * This can take up to 10 usec, but we will wait max 1 ms.
>+	 * Last sector was transfered, wait until device is ready.  This can
>+	 * take up to 6 ms on some ATAPI devices, so we will wait max 10 ms.
> 	 */
>-	for (retries = 0; retries < 100; retries++) {
>+	for (retries = 0; retries < 1000; retries++) {
> 		stat = ide_read_status(drive);
> 
> 		if (stat & BUSY_STAT)

Actions: View | Diff

Attachments on bug 456078: 312253 | 336467