Attachment 312406 Details for Bug 455747 – Initial patch from peterz

Initial patch from peterz

fix-oprofile.patch (text/plain), 2.24 KB, created by IBM Bug Proxy on 2008-07-22 23:30:43 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: IBM Bug Proxy

Created: 2008-07-22 23:30:43 UTC

Size: 2.24 KB

patch

obsolete

>On Tue, 2008-07-22 at 22:33 +0530, Ankita Garg wrote:
>> Hi,
>> 
>> This is regarding the RH buzilla no. RH455747. Very briefly, we have hit an
>> Oops when running oprofile, on all hardware. With some analysis, we see that
>> the last working kernel was -62. Also, removing the slab-fix-rt-v2.patch
>> (which was introduced post -62), oprofile works fine on all the kernels.
>> Details can be found in the bz. Some output from cras hanalysis of the dump
>> has also been updated.
>> 
>> Peter, could you pl take a look at this issue ?
>
>Does something like the below help?
>
>My dual core opteron doesn't crash with either nmi_watchdog=2 nor the
>oprofile case with this (but I failed to test it without the below patch
>- will do so now)
>
>
>Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
>---
>
>Index: linux-2.6.24.7.noarch/arch/x86/kernel/head64.c
>===================================================================
>--- linux-2.6.24.7.noarch.orig/arch/x86/kernel/head64.c
>+++ linux-2.6.24.7.noarch/arch/x86/kernel/head64.c
>@@ -70,6 +70,7 @@ void __init x86_64_start_kernel(char * r
>  		cpu_pda(i) = &boot_cpu_pda[i];
>
> 	pda_init(0);
>+	allocate_stacks(0);
> 	copy_bootdata(__va(real_mode_data));
> #ifdef CONFIG_SMP
> 	cpu_set(0, cpu_online_map);
>Index: linux-2.6.24.7.noarch/arch/x86/kernel/smpboot_64.c
>===================================================================
>--- linux-2.6.24.7.noarch.orig/arch/x86/kernel/smpboot_64.c
>+++ linux-2.6.24.7.noarch/arch/x86/kernel/smpboot_64.c
>@@ -538,7 +538,7 @@ static void __cpuinit do_fork_idle(struc
> static char boot_exception_stacks[(N_EXCEPTION_STACKS - 1) * EXCEPTION_STKSZ + DEBUG_STKSZ]
> __attribute__((section(".bss.page_aligned")));
>
>-static int __cpuinit allocate_stacks(int cpu)
>+int __cpuinit allocate_stacks(int cpu)
> {
> 	static const unsigned int order[N_EXCEPTION_STACKS] = {
> 		[0 ... N_EXCEPTION_STACKS - 1] = EXCEPTION_STACK_ORDER,
>Index: linux-2.6.24.7.noarch/include/asm-x86/proto.h
>===================================================================
>--- linux-2.6.24.7.noarch.orig/include/asm-x86/proto.h
>+++ linux-2.6.24.7.noarch/include/asm-x86/proto.h
>@@ -10,6 +10,7 @@ struct pt_regs;
>
> extern void start_kernel(void);
> extern void pda_init(int); 
>+extern int allocate_stacks(int cpu);
>
> extern void early_idt_handler(void);
>
>
>

Actions: View

Attachments on bug 455747: 312310 | 312406 | 312494