Attachment 312412 Details for Bug 194029 – Patch Improve:

[patch] Patch Improve:

error_messages1.patch (text/plain), 2.40 KB, created by XINSUN on 2008-07-23 02:51:32 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: XINSUN

Created: 2008-07-23 02:51:32 UTC

Size: 2.40 KB

patch

obsolete

>Index: post.cgi
>===================================================================
>RCS file: /cvs/qa/hwcert/post.cgi,v
>retrieving revision 1.59
>diff -u -r1.59 post.cgi
>--- post.cgi	21 Jul 2008 06:11:05 -0000	1.59
>+++ post.cgi	23 Jul 2008 02:44:57 -0000
>@@ -221,7 +221,13 @@
>     } elsif ( $cgi->param('Not_Provided_Pkg') ) {
>         $vendor = $cgi->param('cf_devel_whiteboard');
>         $make  = $cgi->param('status_whiteboard');
>+        if ($make eq "Provided by Package") {
>+           ThrowUserError("missing_make");
>+        }
>         $model = $cgi->param('cf_qa_whiteboard');
>+        if ($model eq "Provided by Package") {
>+           ThrowUserError("missing_model");
>+        }
>         $version = $cgi->param('version');
>         $platform = $cgi->param('platform');
>     } else {
>Index: template/en/default/global/user-error.html.tmpl
>===================================================================
>RCS file: /cvs/qa/hwcert/template/en/default/global/user-error.html.tmpl,v
>retrieving revision 1.16
>diff -u -r1.16 user-error.html.tmpl
>--- template/en/default/global/user-error.html.tmpl	21 Jul 2008 09:56:29 -0000	1.16
>+++ template/en/default/global/user-error.html.tmpl	23 Jul 2008 02:44:57 -0000
>@@ -542,7 +542,15 @@
>   [% ELSIF error == "missing_frequency" %]
>     [% title = "Missing Frequency" %]
>     You did not specify a valid frequency for this series.
>+
>+  [% ELSIF error == "missing_make" %]
>+    [% title = "Missing Make" %]
>+    Please press back to enter the Make info.
>                 
>+  [% ELSIF error == "missing_model" %]
>+    [% title = "Missing Model" %]
>+    Please press back to enter the Model info.
>+
>   [% ELSIF error == "missing_name" %]
>     [% title = "Missing Name" %]
>     You did not specify a name for this series.
>Index: template/en/default/bug/create/post_verify.html.tmpl
>===================================================================
>RCS file: /cvs/qa/hwcert/template/en/default/bug/create/post_verify.html.tmpl,v
>retrieving revision 1.12
>diff -u -r1.12 post_verify.html.tmpl
>--- template/en/default/bug/create/post_verify.html.tmpl	21 Jul 2008 06:11:05 -0000	1.12
>+++ template/en/default/bug/create/post_verify.html.tmpl	23 Jul 2008 02:44:57 -0000
>@@ -97,6 +97,8 @@
>     <td>
>       [% IF bug_file_loc %]
>         <a href="[% bug_file_loc FILTER html %]">[% bug_file_loc FILTER html %]</a>
>+      [% ELSE %]
>+        <span class="rednote">(Not Provided)</span>
>       [% END %]
>     </td>
>   </tr>

Actions: View | Diff

Attachments on bug 194029: 311676 | 312013 | 312014 | 312029 | 312311 | 312312 | 312313 | 312364 | 312382 | 312412