Attachment 312413 Details for Bug 454593 – fixed above comments

[patch] fixed above comments

bug454593-1.patch (text/plain), 6.29 KB, created by eric_liu on 2008-07-23 02:54:57 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: eric_liu

Created: 2008-07-23 02:54:57 UTC

Size: 6.29 KB

patch

obsolete

>Index: template/en/default/bug/edit.html.tmpl
>===================================================================
>RCS file: /cvs/qa/hwcert/template/en/default/bug/edit.html.tmpl,v
>retrieving revision 1.59
>diff -u -r1.59 edit.html.tmpl
>--- template/en/default/bug/edit.html.tmpl	29 Feb 2008 12:09:38 -0000	1.59
>+++ template/en/default/bug/edit.html.tmpl	23 Jul 2008 02:46:26 -0000
>@@ -64,15 +64,18 @@
>       [% PROCESS bug/owners.html.tmpl %]
>       [% PROCESS bug/summary.html.tmpl %]
>       [% PROCESS bug/rh_edit.html.tmpl %]
>+      [% PROCESS bug/status_edit.html.tmpl %]
>       [% PROCESS bug/tam_ack.html.tmpl %]
>       [% PROCESS bug/external_bugzilla.html.tmpl 
>          external_bugs = bug.external_bugs
>          external_bugzilla_list = bug.external_bugzilla_list %]
>     </div>
> 
>     <div id="dialog">
>       [% PROCESS "bug/certification-comments.html.tmpl" %]
>-      [% PROCESS bug/status_edit.html.tmpl %]
>     </div>
> 
>     <div id="review">
>Index: template/en/default/bug/rh_edit.html.tmpl
>===================================================================
>RCS file: /cvs/qa/hwcert/template/en/default/bug/rh_edit.html.tmpl,v
>retrieving revision 1.17
>diff -u -r1.17 rh_edit.html.tmpl
>--- template/en/default/bug/rh_edit.html.tmpl	29 Feb 2008 12:12:29 -0000	1.17
>+++ template/en/default/bug/rh_edit.html.tmpl	23 Jul 2008 02:46:26 -0000
>@@ -4,7 +4,7 @@
>     [% IF user.login && UserInGroup('hwcert_edit') %]
> 
>       <hr/>
>-
>+      <h2>  rh_edit.html.tmpl </h2>
>       <h3>Edit Certification Information</h3>
> 
>       <p>
>@@ -70,8 +70,6 @@
>       <input type="submit" name="submit" value="Save Changes">
>     [% END %]
> 
>-
>-      <hr/>
>     [% IF debug %]
>       <pre>[% debug %]</pre>
>     [% END %]
>Index: template/en/default/bug/status_edit.html.tmpl
>===================================================================
>RCS file: /cvs/qa/hwcert/template/en/default/bug/status_edit.html.tmpl,v
>retrieving revision 1.6
>diff -u -r1.6 status_edit.html.tmpl
>--- template/en/default/bug/status_edit.html.tmpl	20 May 2008 02:31:21 -0000	1.6
>+++ template/en/default/bug/status_edit.html.tmpl	23 Jul 2008 02:46:26 -0000
>@@ -1,27 +1,14 @@
>-    <p>
>+<hr/>
>+ <p>
> 
>     [% IF canedit %]
> 
>-      <hr/>
>+      <h3>Certification Status</h3>
> 
>-      <h3>Edit Dialog Status</h3>
>-
>-      [% IF bug.bug_status != 'CLOSED' %]
>-        [% IF bug.bug_status == 'MODIFIED' %]
>-           [% tmp.status = 'Pending TAM response' %]
>-        [% ELSIF bug.bug_status == 'ON_QA' %]
>-           [% tmp.status = 'Pending Reviewer response' %]
>-        [% ELSIF bug.bug_status == 'NEEDINFO' %]
>-           [% tmp.status = 'Pending for Vendor response' %]
>-        [% ELSIF bug.bug_status == 'NEW' %]
>-           [% tmp.status = 'Pending for Vendor response' %]
>-        [% ELSIF bug.bug_status == 'ASSIGNED' %]
>-           [% tmp.status = 'No Response Pending' %]
>-        [% ELSE %]
>-           [% tmp.status = 'INPROGRESS' %]
>-        [% END %]
>+      [% IF bug.bug_status != 'CLOSED' %]    
>+           [% tmp.status = 'IN PROGRESS' %]
>       [% ELSE %]
>-        [% tmp.status = bug.bug_status %]
>+        [% tmp.status = 'CLOSED/CERTIFIED' %]
>       [% END %]
> 
>       [% IF bug.resolution == 'CURRENTRELEASE' %]
>@@ -40,7 +27,7 @@
>         <th>
>         <input type="radio" id="knob-leave" name="knob" value="none" checked="checked">
>         <label for="knob-leave">
>-          Leave as <b>[% tmp.status %][% IF bug.bug_status == 'CLOSED' %]&nbsp;[% tmp.resolution %][% END %]</b>
>+        Leave as  <b>[% tmp.status %]</b>
>         </label>
>         </th>
>       </tr>
>@@ -50,7 +37,7 @@
>         <th>
>         <input id="knob-changestatus" type="radio" name="knob" value="changestatus" [% " disabled" IF !UserInGroup('hwcert_edit') && !isprivate %]> 
>         <input type="hidden" name="newstatus" value="needinfo" [% " disabled" IF !UserInGroup('hwcert_edit') && !isprivate %]>
>-        <label for="knob-changestatus">Re-Open Certification, Change status to NEEDINFO</label>
>+        <label for="knob-changestatus">Re-Open certification as IN PROGRESS</label>
>         </th>
>       </tr>
>          [% IF !UserInGroup('hwcert_edit') && !isprivate %] 
>@@ -63,30 +50,14 @@
>       [% END %]
> 
>       [% IF bug.bug_status != 'CLOSED' %]
>-      <tr>
>-        <th>
>-        <input id="knob-changestatus" type="radio" name="knob" value="changestatus"/>
>-        <label for="knob-changestatus">Change status to</label> 
>-        <select name="newstatus" onchange="document.changeform.knob[1].checked=true;">
>-          <option value="needinfo" title="Pending Vendor response">Pending Vendor Response</option>
>-          <option value="on_qa" title="Pending Reviewer Response">Pending Reviewer Response</option>
>-          <option value="modified" title="Pending TAM Response">Pending TAM Response</option>
>-          <option value="assigned" title="No Response Pending">No Response Pending</option>
>-        </select>
>-        <input type="hidden" name="needinfo_override" value="1"/>
>-        </th>
>-      </tr>
>       [% IF user.login && UserInGroup('hwcert_edit') %]
>       <tr>
>         <th>
>         <input id="knob-resolve" type="radio" name="knob" value="resolve"/>
>+           Change status to
>         <label for="knob-resolve">
>-          Close certification, changing resolution to
>-          <select name="resolution" onchange="document.changeform.knob[1].checked=true;">
>-            <option value="CURRENTRELEASE">CERTIFIED</option>
>-            <option value="RAWHIDE">COMPATIBLE</option>
>-            <option value="WONTFIX">UNCERTIFIED</option>
>-          </select>
>+           CLOSED/CERTIFIED
>+          <input type="hidden" name="resolution" value="CURRENTRELEASE" />
>         </label>
>         </th>
>       </tr>
>@@ -100,4 +71,3 @@
>   [% ELSE %]
>     <input type="hidden" name="knob" value="none">
>   [% END %]
>-
>Index: template/en/default/bug/tam_ack.html.tmpl
>===================================================================
>RCS file: /cvs/qa/hwcert/template/en/default/bug/tam_ack.html.tmpl,v
>retrieving revision 1.2
>diff -u -r1.2 tam_ack.html.tmpl
>--- template/en/default/bug/tam_ack.html.tmpl	29 Feb 2008 12:13:41 -0000	1.2
>+++ template/en/default/bug/tam_ack.html.tmpl	23 Jul 2008 02:46:26 -0000
>@@ -1,4 +1,4 @@
>-
>+<hr>
>     [% IF ( (user.login && user.login == bug.reporter.login) || UserInGroup('hwcert_edit') ) %] 
>       [% IF UserInGroup('support') || UserInGroup('hwcert_edit')%]
>       <h2>GSS Requirements</h2>

Actions: View | Diff

Attachments on bug 454593: 312231 | 312356 | 312360 | 312381 | 312413 | 312693 | 312921