Attachment 312985 Details for Bug 203231 – Updated patch (style fixes)

[patch] Updated patch (style fixes)

1.patch (text/plain), 1.66 KB, created by Denys Vlasenko on 2008-07-30 11:55:52 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Denys Vlasenko

Created: 2008-07-30 11:55:52 UTC

Size: 1.66 KB

patch

obsolete

>diff -d -urpN gcc.0/libiberty/make-temp-file.c gcc.1/libiberty/make-temp-file.c
>--- gcc.0/libiberty/make-temp-file.c	2008-07-21 14:50:00.000000000 +0200
>+++ gcc.1/libiberty/make-temp-file.c	2008-07-30 13:23:04.000000000 +0200
>@@ -23,6 +23,7 @@ Boston, MA 02110-1301, USA.  */
> 
> #include <stdio.h>	/* May get P_tmpdir.  */
> #include <sys/types.h>
>+#include <errno.h>
> #ifdef HAVE_UNISTD_H
> #include <unistd.h>
> #endif
>@@ -166,11 +167,14 @@ make_temp_file (const char *suffix)
>   strcpy (temp_filename + base_len + TEMP_FILE_LEN, suffix);
> 
>   fd = mkstemps (temp_filename, suffix_len);
>-  /* If mkstemps failed, then something bad is happening.  Maybe we should
>-     issue a message about a possible security attack in progress?  */
>+  /* Mkstemps failed.  It may be EPERM, ENOSPC etc.  */
>   if (fd == -1)
>-    abort ();
>-  /* Similarly if we can not close the file.  */
>+    {
>+      fprintf(stderr, "Cannot create temporary file in %s: %s\n",
>+	      base, strerror(errno));
>+      abort ();
>+    }
>+  /* We abort on failed close out of sheer paranoia.  */
>   if (close (fd))
>     abort ();
>   return temp_filename;
>diff -d -urpN gcc.0/libiberty/mkstemps.c gcc.1/libiberty/mkstemps.c
>--- gcc.0/libiberty/mkstemps.c	2008-07-21 14:50:00.000000000 +0200
>+++ gcc.1/libiberty/mkstemps.c	2008-07-28 18:48:34.000000000 +0200
>@@ -127,6 +127,9 @@ mkstemps (char *pattern, int suffix_len)
>       if (fd >= 0)
> 	/* The file does not exist.  */
> 	return fd;
>+      if (errno != EEXIST)
>+	/* Fatal error (EPERM, ENOSPC etc). Doesn't make sense to loop.  */
>+	break;
> 
>       /* This is a random value.  It is only necessary that the next
> 	 TMP_MAX values generated by adding 7777 to VALUE are different

Actions: View | Diff

Attachments on bug 203231: 312263 | 312795 | 312985