Attachment 313302 Details for Bug 457707 – v1 patch to allow all logged in users to update external bugs on any bug

[patch] v1 patch to allow all logged in users to update external bugs on any bug

external_bug.patch (text/plain), 2.49 KB, created by Noura El hawary on 2008-08-04 04:32:20 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Noura El hawary

Created: 2008-08-04 04:32:20 UTC

Size: 2.49 KB

patch

obsolete

>Index: extensions/external_bugs/code/update_bug_data.pl
>===================================================================
>RCS file: /cvs/qa/rh_bugzilla_3/extensions/external_bugs/code/update_bug_data.pl,v
>retrieving revision 1.1
>diff -p -u -r1.1 update_bug_data.pl
>--- extensions/external_bugs/code/update_bug_data.pl	9 May 2008 14:29:52 -0000	1.1
>+++ extensions/external_bugs/code/update_bug_data.pl	4 Aug 2008 04:24:12 -0000
>@@ -35,9 +35,7 @@ my $external_bug_id = $cgi->param('exter
> Bugzilla->logger->debug("Starting: $external_id, $external_bug_id");
> 
> # Insert new reference
>-if ( $external_id && $external_bug_id) {
>-    $bug->check_can_change_field('external_bugs', 0, 1, \$privs)
>-        || ThrowUserError('illegal_change', { field => 'external_bugs', privs => $privs });
>+if ( $external_id && $external_bug_id && Bugzilla->user->id) {
>     Bugzilla->logger->debug("Starting: external_bugs->add($external_id, $external_bug_id)");
>     $bug->external_bugs->add(
>         external_id     => $external_id,
>Index: extensions/external_bugs/template/en/bug/edit-table-data.html.tmpl
>===================================================================
>RCS file: /cvs/qa/rh_bugzilla_3/extensions/external_bugs/template/en/bug/edit-table-data.html.tmpl,v
>retrieving revision 1.2
>diff -p -u -r1.2 edit-table-data.html.tmpl
>--- extensions/external_bugs/template/en/bug/edit-table-data.html.tmpl	3 Jul 2008 16:42:10 -0000	1.2
>+++ extensions/external_bugs/template/en/bug/edit-table-data.html.tmpl	4 Aug 2008 04:24:25 -0000
>@@ -21,7 +21,7 @@
> <br>
> <table id="external_bugs_table" cellspacing="0" cellpadding="4">
>   <tr>
>-    <th colspan="[% bug.check_can_change_field('external_bugs', 0, 1) ? "5" : "4" %]" align="left">
>+    <th colspan="[% user.id ? "5" : "4" %]" align="left">
>       <a name="a0" id="a0">External [% terms.Bugs %]</a>
>     </th>
>   </tr>
>@@ -41,7 +41,7 @@
>         [% IF extbz.short_summary %]<span title="[% extbz.long_summary FILTER html %]">
>         [% extbz.short_summary FILTER html %]</span>[% ELSE %]No Description[% END %]
>       </td>
>-      [% IF bug.check_can_change_field('external_bugs', 0, 1) %]
>+      [% IF user.id %]
>         <td valign="top">
>           <input type="checkbox"
>                  name="rem_ext_[% extbz.id FILTER html %]_[% extbz.bug_id FILTER html %]" value="1"/>
>@@ -51,7 +51,7 @@
>     </tr>
>   [% END %]
> 
>-  [% IF bug.check_can_change_field('external_bugs', 0, 1) %]
>+  [% IF user.id %]
>     <tr class="bz_attach_footer">
>       <td colspan="5">
>       Add External [% terms.Bug %]:  Location

Flags:

dkl: review+

Actions: View | Diff

Attachments on bug 457707: 313302