Attachment 313445 Details for Bug 451399 – avoid checking _STA method

avoid checking _STA method

acpi-dock-avoid-check-sta.patch (text/plain), 1.24 KB, created by Holger Macht on 2008-08-05 11:57:02 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Holger Macht

Created: 2008-08-05 11:57:02 UTC

Size: 1.24 KB

patch

obsolete

>From: Shaohua Li <shaohua.li@intel.com>
>
>In some BIOSes, every _STA method call will send a notification again,
>this cause freeze. And in some BIOSes, it appears _STA should be called
>after _DCK. This tries to avoid calls _STA, and still keep the device
>present check.
>
>http://bugzilla.kernel.org/show_bug.cgi?id=10431
>
>Signed-off-by: Shaohua Li <shaohua.li@intel.com>
>
>---
> drivers/acpi/dock.c |    4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
>Index: linux/drivers/acpi/dock.c
>===================================================================
>--- linux.orig/drivers/acpi/dock.c	2008-05-26 10:49:42.000000000 +0800
>+++ linux/drivers/acpi/dock.c	2008-06-05 09:09:13.000000000 +0800
>@@ -599,14 +599,16 @@ static int handle_eject_request(struct d
> static void dock_notify(acpi_handle handle, u32 event, void *data)
> {
> 	struct dock_station *ds = data;
>+	struct acpi_device *tmp;
> 
> 	switch (event) {
> 	case ACPI_NOTIFY_BUS_CHECK:
>-		if (!dock_in_progress(ds) && dock_present(ds)) {
>+		if (!dock_in_progress(ds) && acpi_bus_get_device(ds->handle, &tmp)) {
> 			begin_dock(ds);
> 			dock(ds);
> 			if (!dock_present(ds)) {
> 				printk(KERN_ERR PREFIX "Unable to dock!\n");
>+				complete_dock(ds);
> 				break;
> 			}
> 			atomic_notifier_call_chain(&dock_notifier_list,
>
>

Actions: View

Attachments on bug 451399: 311123 | 312909 | 312910 | 312911 | 312912 | 312913 | 312914 | 313011 | 313445 | 316628