Attachment 313512 Details for Bug 457995 – Upstream patch for this issue

[patch] Upstream patch for this issue

0001-sound-ensure-device-number-is-valid-in-snd_seq_oss_.patch (text/plain), 1.24 KB, created by Eugene Teo (Security Response) on 2008-08-06 02:05:43 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Eugene Teo (Security Response)

Created: 2008-08-06 02:05:43 UTC

Size: 1.24 KB

patch

obsolete

>From 82e68f7ffec3800425f2391c8c86277606860442 Mon Sep 17 00:00:00 2001
>From: Willy Tarreau <w@1wt.eu>
>Date: Sat, 2 Aug 2008 18:25:16 +0200
>Subject: [PATCH] sound: ensure device number is valid in snd_seq_oss_synth_make_info
>
>snd_seq_oss_synth_make_info() incorrectly reports information
>to userspace without first checking for the validity of the
>device number, leading to possible information leak (CVE-2008-3272).
>
>Reported-By: Tobias Klein <tk@trapkit.de>
>Acked-and-tested-by: Takashi Iwai <tiwai@suse.de>
>Cc: stable@kernel.org
>Signed-off-by: Willy Tarreau <w@1wt.eu>
>Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
>---
> sound/core/seq/oss/seq_oss_synth.c |    3 +++
> 1 files changed, 3 insertions(+), 0 deletions(-)
>
>diff --git a/sound/core/seq/oss/seq_oss_synth.c b/sound/core/seq/oss/seq_oss_synth.c
>index 558dadb..e024e45 100644
>--- a/sound/core/seq/oss/seq_oss_synth.c
>+++ b/sound/core/seq/oss/seq_oss_synth.c
>@@ -604,6 +604,9 @@ snd_seq_oss_synth_make_info(struct seq_oss_devinfo *dp, int dev, struct synth_in
> {
> 	struct seq_oss_synth *rec;
> 
>+	if (dev < 0 || dev >= dp->max_synthdev)
>+		return -ENXIO;
>+
> 	if (dp->synths[dev].is_midi) {
> 		struct midi_info minf;
> 		snd_seq_oss_midi_make_info(dp, dp->synths[dev].midi_mapped, &minf);
>-- 
>1.5.5.1
>

Actions: View | Diff

Attachments on bug 457995: 313512