Attachment 313587 Details for Bug 458026 – Patch to fix domain name in the in-reply-to mail header (v1)

[patch] Patch to fix domain name in the in-reply-to mail header (v1)

in_reply_to_domain.patch (text/plain), 983 bytes, created by David Lawrence on 2008-08-06 15:38:37 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: David Lawrence

Created: 2008-08-06 15:38:37 UTC

Size: 983 bytes

patch

obsolete

>Index: Bugzilla/BugMail.pm
>===================================================================
>RCS file: /cvs/qa/rh_bugzilla_3/Bugzilla/BugMail.pm,v
>retrieving revision 1.16
>diff -u -r1.16 BugMail.pm
>--- Bugzilla/BugMail.pm	5 Aug 2008 23:20:51 -0000	1.16
>+++ Bugzilla/BugMail.pm	6 Aug 2008 15:33:27 -0000
>@@ -696,7 +696,10 @@
>     push @watchingrel, map { user_id_to_login($_) } @$watchingRef;
> 
>     my $sitespec = '@' . Bugzilla->params->{'urlbase'};
>-    $sitespec =~ s/:\/\//\./; # Make the protocol look like part of the domain
>+    # Remove https from the domain name as this causes in-reply-to header to be different 
>+    # than previous Bugzilla behaviour
>+    # REDHAT Bug 458026 - In-Reply-To in notification emails changed format; threading broke
>+    $sitespec =~ s/https?:\/\/([^:\/]+)\//$1/;
>     $sitespec =~ s/^([^:\/]+):(\d+)/$1/; # Remove a port number, to relocate
>     if ($2) {
>         $sitespec = "-$2$sitespec"; # Put the port number back in, before the '@'

Flags:

nelhawar: review+

Actions: View | Diff

Attachments on bug 458026: 313587