Attachment 313625 Details for Bug 457961 – kernel patch to resolve problem

[patch] kernel patch to resolve problem

linux-ia64-kprobes-null.patch (text/plain), 1.65 KB, created by William Cohen on 2008-08-06 18:40:20 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: William Cohen

Created: 2008-08-06 18:40:20 UTC

Size: 1.65 KB

patch

obsolete

>From: Akiyama, Nobuyuki <akiyama.nobuyuk@jp.fujitsu.com>
>Date: Thu, 17 Jul 2008 18:22:01 +0000 (-0700)
>Subject:     [IA64] adding parameter check to module_free()
>X-Git-Tag: next-20080721~39^2~4
>X-Git-Url: http://git.kernel.org/?p=linux%2Fkernel%2Fgit%2Fsfr%2Flinux-next.git;a=commitdiff_plain;h=740a8de0796dd12890b3c8ddcfabfcb528b78d40;hp=60192db82952ad56ef7bbc4a318e2041ca65ba7d
>
>[IA64] adding parameter check to module_free()
>
>    module_free() refers the first parameter before checking.
>    But it is called like below(in kernel/kprobes). The first parameter is always NULL.
>This happens when many probe points(>1024) are set by kprobes.
>I encountered this with using SystemTap. It can set many probes easily.
>
>static int __kprobes collect_one_slot(struct kprobe_insn_page *kip, int idx)
>{
>...
>    if (kip->nused == 0) {
>	    hlist_del(&kip->hlist);
>	    if (hlist_empty(&kprobe_insn_pages)) {
>		...
>	    } else {
>		    module_free(NULL, kip->insns); //<<< 1st param always NULL
>		    kfree(kip);
>	    }
>	    return 1;
>    }
>    return 0;
>}
>
>Signed-off-by: Akiyama, Nobuyuki <akiyama.nobuyuk@jp.fujitsu.com>
>Signed-off-by: Tony Luck <tony.luck@intel.com>
>---
>
>diff --git a/arch/ia64/kernel/module.c b/arch/ia64/kernel/module.c
>index e83e2ea..29aad34 100644
>--- a/arch/ia64/kernel/module.c
>+++ b/arch/ia64/kernel/module.c
>@@ -321,7 +321,8 @@ module_alloc (unsigned long size)
> void
> module_free (struct module *mod, void *module_region)
> {
>-	if (mod->arch.init_unw_table && module_region == mod->module_init) {
>+	if (mod && mod->arch.init_unw_table &&
>+	    module_region == mod->module_init) {
> 		unw_remove_unwind_table(mod->arch.init_unw_table);
> 		mod->arch.init_unw_table = NULL;
> 	}

Actions: View | Diff

Attachments on bug 457961: 313480 | 313625