Attachment 313631 Details for Bug 457856 – Patch to add ability to edit dependencies on multi-edit bug form (v1)

[patch] Patch to add ability to edit dependencies on multi-edit bug form (v1)

multi_edit_dependencies.patch (text/plain), 3.52 KB, created by David Lawrence on 2008-08-06 20:05:29 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: David Lawrence

Created: 2008-08-06 20:05:29 UTC

Size: 3.52 KB

patch

obsolete

>Index: process_bug.cgi
>===================================================================
>RCS file: /cvs/qa/rh_bugzilla_3/process_bug.cgi,v
>retrieving revision 1.25
>diff -u -r1.25 process_bug.cgi
>--- process_bug.cgi	15 May 2008 18:57:14 -0000	1.25
>+++ process_bug.cgi	6 Aug 2008 20:01:03 -0000
>@@ -284,17 +284,41 @@
>     }
> }
> 
>+# REDHAT EXTENSION START 457856
>+# Bug 457856 - update dependson and blocked on several bugs not available in 3.2
> if ($cgi->param('id') && (defined $cgi->param('dependson')
>                           || defined $cgi->param('blocked')) )
> {
>     $first_bug->set_dependencies(scalar $cgi->param('dependson'),
>                                  scalar $cgi->param('blocked'));
> }
>-# Right now, you can't modify dependencies on a mass change.
> else {
>-    $cgi->delete('dependson');
>-    $cgi->delete('blocked');
>+    if (defined $cgi->param('dependson') 
>+        && $cgi->param('dependson_action') =~ /^(add|remove)$/) {
>+        foreach my $bug (@bug_objects) {
>+            my %seen_deps;
>+            map { $seen_deps{$_} = 1 } @{$bug->dependson};
>+            foreach my $id (split(/[,\s+]+/, $cgi->param('dependson'))) {
>+                $seen_deps{$id} = 1 if $cgi->param('dependson_action') eq 'add';
>+                delete $seen_deps{$id} if $cgi->param('dependson_action') eq 'remove';
>+            }
>+            $bug->set_dependencies(join(' ', keys %seen_deps), join(' ', @{$bug->blocked})); 
>+        }
>+    }
>+    if (defined $cgi->param('blocked') 
>+        && $cgi->param('blocked_action') =~ /^(add|remove)$/) {
>+        foreach my $bug (@bug_objects) {
>+            my %seen_deps; 
>+            map { $seen_deps{$_} = 1 } @{$bug->blocked};
>+            foreach my $id (split(/[,\s+]+/, $cgi->param('blocked'))) {
>+                $seen_deps{$id} = 1 if $cgi->param('blocked_action') eq 'add';
>+                delete $seen_deps{$id} if $cgi->param('blocked_action') eq 'remove';
>+            }
>+            $bug->set_dependencies(join(' ', @{$bug->dependson}), join(' ', keys %seen_deps));
>+        }
>+    }
> }
>+# REDHAT EXTENSION END 457856
> 
> my $any_keyword_changes;
> if (defined $cgi->param('keywords')) {
>Index: template/en/default/list/edit-multiple.html.tmpl
>===================================================================
>RCS file: /cvs/qa/rh_bugzilla_3/template/en/default/list/edit-multiple.html.tmpl,v
>retrieving revision 1.9
>diff -u -r1.9 edit-multiple.html.tmpl
>--- template/en/default/list/edit-multiple.html.tmpl	16 Jun 2008 14:06:45 -0000	1.9
>+++ template/en/default/list/edit-multiple.html.tmpl	6 Aug 2008 20:01:03 -0000
>@@ -232,6 +232,39 @@
>     </tr>
>   [% END %]
> 
>+  [%# REDHAT EXTENSION START 457856
>+    # Bug 457856 - update dependson and blocked on several bugs not available in 3.2 %]
>+  <tr>
>+    <th>
>+      <label for="dependson">
>+          Depends On:
>+      </label>
>+    </th>
>+    <td colspan="3">
>+      <input id="dependson" name="dependson" size="32">
>+      <select name="dependson_action">
>+          <option value="add">Add these IDs</option>
>+          <option value="remove">Delete these IDs</option>
>+      </select>
>+    </td>
>+  </tr>
>+
>+  <tr>
>+    <th>
>+      <label for="blocked">
>+          Blocks:
>+      </label>
>+    </th>
>+    <td colspan="3">
>+      <input id="blocked" name="blocked" size="32">
>+      <select name="blocked_action">
>+          <option value="add">Add these IDs</option>
>+          <option value="remove">Delete these IDs</option>
>+      </select>
>+    </td>
>+  </tr>
>+  [%# REDHAT EXTENSION END 457856 %]
>+
>   [% IF Param('usestatuswhiteboard') %]
>     <tr>
>       <td align="right">

Flags:

nelhawar: review+

Actions: View | Diff

Attachments on bug 457856: 313631