Attachment 313727 Details for Bug 458224 – v1 patch to removed duplicate ccid entries to the cc table.

[patch] v1 patch to removed duplicate ccid entries to the cc table.

duplicate_cc.patch (text/plain), 1.44 KB, created by Noura El hawary on 2008-08-07 18:03:36 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Noura El hawary

Created: 2008-08-07 18:03:36 UTC

Size: 1.44 KB

patch

obsolete

>Index: Bugzilla/Bug.pm
>===================================================================
>RCS file: /cvs/qa/rh_bugzilla_3/Bugzilla/Bug.pm,v
>retrieving revision 1.49
>diff -p -u -r1.49 Bug.pm
>--- Bugzilla/Bug.pm	30 Jul 2008 19:45:27 -0000	1.49
>+++ Bugzilla/Bug.pm	7 Aug 2008 17:56:07 -0000
>@@ -387,6 +387,7 @@ sub create {
>     # REDHAT EXTENSION START 406321
>     # REDHAT If group is security, then add security-response-team@redhat.com 
>     # REDHAT to cclist and only allow cc's in the groups assigned.
>+    my %tempccids;
>     foreach my $groupid (@$groups) {
>         if ($groupid == 71) {
>             my $ccid = login_to_id("security-response-team\@redhat.com");
>@@ -394,18 +395,17 @@ sub create {
>             map { $unique_ccids{$_} = 1 } @$cc_ids;
>             push (@$cc_ids, $ccid) if !$unique_ccids{$ccid};
> 
>-            my @tempccids = ();
>             foreach my $gid (@$groups) {
>                 my $group_obj = new Bugzilla::Group($gid);
>                 my $gname = $group_obj->name;
>                 foreach my $ccid (@$cc_ids) {
>                     my $cc_user =  new Bugzilla::User($ccid);
>                     if ($cc_user->in_group($gname)){
>-                        push @tempccids, $ccid;
>+                        $tempccids{$ccid} = 1;
>                     }
>                 }
>             }
>-            @$cc_ids = @tempccids;
>+            @$cc_ids = keys %tempccids;
> 
>             # Add Security keyword
>             my $keyword_found = 0;

Flags:

dkl: review+

Actions: View | Diff

Attachments on bug 458224: 313727