Attachment 313734 Details for Bug 458340 – Proposed patch for -76

[patch] Proposed patch for -76

bz458340--parse_pmtmr-stores_ulong_in_u32.patch (text/plain), 1.11 KB, created by Luis Claudio R. Goncalves on 2008-08-07 19:21:55 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Luis Claudio R. Goncalves

Created: 2008-08-07 19:21:55 UTC

Size: 1.11 KB

patch

obsolete

>https://bugzilla.redhat.com/show_bug.cgi?id=458340
>
>Description of problem:
>
>From drivers/clocksource/acpi_pm.c:
>
>u32 pmtmr_ioport __read_mostly;
>...
>
>/*
> * Allow an override of the IOPort. Stupid BIOSes do not tell us about
> * the PMTimer, but we might know where it is.
> */
>static int __init parse_pmtmr(char *arg)
>{
>        unsigned long base;
>        ...
>        base = simple_strtoul(arg, &e, 16);
>        ...
>        pmtmr_ioport = base;
>        ...
>}
>
>Signed-off-by: Luis Claudio R. Goncalves <lgoncalv@redhat.com>
>
>---
>diff --git a/drivers/clocksource/acpi_pm.c b/drivers/clocksource/acpi_pm_new.c
>index a9e96a9..bd9ffad 100644
>--- a/drivers/clocksource/acpi_pm.c
>+++ b/drivers/clocksource/acpi_pm_new.c
>@@ -222,12 +222,12 @@ fs_initcall(init_acpi_pm_clocksource);
>  */
> static int __init parse_pmtmr(char *arg)
> {
>-	unsigned long base;
>+	u32 base;
> 	char *e;
> 
>-	base = simple_strtoul(arg, &e, 16);
>+	base = (u32) simple_strtoul(arg, &e, 16);
> 
>-	printk(KERN_INFO "PMTMR IOPort override: 0x%04lx -> 0x%04lx\n",
>+	printk(KERN_INFO "PMTMR IOPort override: 0x%04x -> 0x%04x\n",
> 	       pmtmr_ioport, base);
> 	pmtmr_ioport = base;
>

Actions: View | Diff

Attachments on bug 458340: 313734