Attachment 313741 Details for Bug 458360 – header patch

[patch] header patch

don.patch (text/plain), 2.74 KB, created by Don Zickus on 2008-08-07 19:43:45 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Don Zickus

Created: 2008-08-07 19:43:45 UTC

Size: 2.74 KB

patch

obsolete

>commit 704e9bfd9bbfb2969e8b85c5c7af5a6e6413c5f3
>Author: Don Zickus <dzickus@redhat.com>
>Date:   Thu Aug 7 15:04:59 2008 -0400
>
>    cleanup header warnings and enable header check
>    
>    A bunch of warnings were issued during the build complaining about userspace
>    headers accessing non-existing kernel headers.  These warnings came from the
>    fact we did not strip the userspace header files of the #ifdef __KERNEL__
>    tags.  This is done by the tool unifdef.
>    
>    This patch fixes those warnings and allows applications to use those headers
>    files now.  In addition, I have enabled the header file check to FAIL
>    instead of WARN on these messages now.  This will allow us to catch these
>    problems earlier instead of randomly in beta during an application rebuild.
>    
>    Please ACK.
>    
>    Cheers,
>    Don
>
>diff --git a/include/linux/Kbuild b/include/linux/Kbuild
>index 7870517..05d7251 100644
>--- a/include/linux/Kbuild
>+++ b/include/linux/Kbuild
>@@ -75,9 +75,7 @@ header-y += hpfs_fs.h
> header-y += hysdn_if.h
> header-y += i2c-dev.h
> header-y += i8k.h
>-header-y += icmp.h
> header-y += if_arcnet.h
>-header-y += if_arp.h
> header-y += if_bonding.h
> header-y += if_cablemodem.h
> header-y += if_fc.h
>@@ -94,7 +92,6 @@ header-y += if_tunnel.h
> header-y += in6.h
> header-y += in_route.h
> header-y += ioctl.h
>-header-y += ip.h
> header-y += ipmi_msgdefs.h
> header-y += ip_mp_alg.h
> header-y += ipsec.h
>@@ -161,7 +158,6 @@ header-y += toshiba.h
> header-y += ultrasound.h
> header-y += un.h
> header-y += utime.h
>-header-y += utsname.h
> header-y += video_decoder.h
> header-y += video_encoder.h
> header-y += videotext.h
>@@ -226,8 +222,10 @@ unifdef-y += hiddev.h
> unifdef-y += hpet.h
> unifdef-y += i2c.h
> unifdef-y += i2o-dev.h
>+unifdef-y += icmp.h
> unifdef-y += icmpv6.h
> unifdef-y += if_addr.h 
>+unifdef-y += if_arp.h
> unifdef-y += if_bridge.h
> unifdef-y += if_ec.h
> unifdef-y += if_eql.h
>@@ -245,6 +243,7 @@ unifdef-y += inet_diag.h
> unifdef-y += in.h
> unifdef-y += inotify.h
> unifdef-y += input.h
>+unifdef-y += ip.h
> unifdef-y += ipc.h
> unifdef-y += ipmi.h
> unifdef-y += ipv6.h
>@@ -343,6 +342,7 @@ unifdef-y += unistd.h
> unifdef-y += usb_ch9.h
> unifdef-y += usbdevice_fs.h
> unifdef-y += user.h
>+unifdef-y += utsname.h
> unifdef-y += videodev2.h
> unifdef-y += videodev.h
> unifdef-y += wait.h
>diff --git a/redhat/kernel-2.6.spec.template b/redhat/kernel-2.6.spec.template
>index adf4ed4..621f7f0 100644
>--- a/redhat/kernel-2.6.spec.template
>+++ b/redhat/kernel-2.6.spec.template
>@@ -2003,7 +2003,7 @@ echo -e '*****\n*****' >> hdrwarnings.txt
> if grep -q exist hdrwarnings.txt; then
>    sed s:^$RPM_BUILD_ROOT/usr/include/:: hdrwarnings.txt
>    # Temporarily cause a build failure if header inconsistencies.
>-   # exit 1
>+   exit 1
> fi
> 
> # glibc provides scsi headers for itself, for now

Actions: View | Diff

Attachments on bug 458360: 313741