Attachment 313773 Details for Bug 440072 – Patch Improve:

[patch] Patch Improve:

clone.patch (text/plain), 2.06 KB, created by XINSUN on 2008-08-08 02:33:18 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: XINSUN

Created: 2008-08-08 02:33:18 UTC

Size: 2.06 KB

patch

obsolete

>Index: post.cgi
>===================================================================
>RCS file: /cvs/qa/hwcert/post.cgi,v
>retrieving revision 1.61
>diff -u -r1.61 post.cgi
>--- post.cgi	1 Aug 2008 03:46:54 -0000	1.61
>+++ post.cgi	8 Aug 2008 02:23:16 -0000
>@@ -575,11 +575,18 @@
>     #    $qa_contact = FetchOneColumn();
>     # }
> 
>-    SendSQL("SELECT initialqacontact FROM components WHERE id = $component_id");
>-    my $qa_contact = FetchOneColumn();
>-
>-    if (defined $qa_contact && $qa_contact != 0) {
>-        $::FORM{'qa_contact'} = $qa_contact;
>+    # Default qa_contact is the component initialqacontact.
>+    if (!defined $::FORM{'qa_contact'} || $::FORM{'qa_contact'} eq "") {
>+        SendSQL("SELECT initialqacontact FROM components " .
>+                "WHERE id = $component_id");
>+        my $qa_contact = FetchOneColumn();
>+
>+        if (defined $qa_contact && $qa_contact != 0) {
>+            $::FORM{'qa_contact'} = $qa_contact;
>+            push(@bug_fields, "qa_contact");
>+        }
>+    } else {
>+        $::FORM{'qa_contact'} = DBNameToIdAndCheck(trim($::FORM{'qa_contact'}));
>         push(@bug_fields, "qa_contact");
>     }
> }
>Index: template/en/default/bug/clone.html.tmpl
>===================================================================
>RCS file: /cvs/qa/hwcert/template/en/default/bug/clone.html.tmpl,v
>retrieving revision 1.5
>diff -u -r1.5 clone.html.tmpl
>--- template/en/default/bug/clone.html.tmpl	21 Jul 2008 06:11:05 -0000	1.5
>+++ template/en/default/bug/clone.html.tmpl	8 Aug 2008 02:23:16 -0000
>@@ -24,7 +24,7 @@
>       <input type="hidden" name="reporter_accessible" value="[% bug.reporter_accessible FILTER html %]">
>       <input type="hidden" name="cclist_accessible" value="[% bug.cclist_accessible FILTER html %]">
>       <input type="hidden" name="qa_contact" value="[% bug.qa_contact.email FILTER html %]">
>-      <input type="hidden" name="assigned_to" value="[% bug.qa_contact.email FILTER html %]">
>+      <input type="hidden" name="assigned_to" value="[% bug.assigned_to.email FILTER html %]">
> 
>       [% FOREACH group = bug.groups %]
>         [% IF group.ison %]

Actions: View | Diff

Attachments on bug 440072: 313669 | 313773 | 313902