Attachment 313854 Details for Bug 457156 – diffs - memory leaks

[patch] diffs - memory leaks

diffs.bug457156 (text/plain), 1.35 KB, created by Rich Megginson on 2008-08-08 23:35:20 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Rich Megginson

Created: 2008-08-08 23:35:20 UTC

Size: 1.35 KB

patch

obsolete

>Index: ldapserver/ldap/servers/plugins/acl/acleffectiverights.c
>===================================================================
>RCS file: /cvs/dirsec/ldapserver/ldap/servers/plugins/acl/acleffectiverights.c,v
>retrieving revision 1.12
>diff -u -8 -r1.12 acleffectiverights.c
>--- ldapserver/ldap/servers/plugins/acl/acleffectiverights.c	31 Jul 2008 21:27:26 -0000	1.12
>+++ ldapserver/ldap/servers/plugins/acl/acleffectiverights.c	8 Aug 2008 23:32:49 -0000
>@@ -644,16 +644,17 @@
> 						{
> 							isextensibleobj = 1;
> 						}
> 						charray_merge_nodup(&allattrs, myattrs, 1/*copy_strs*/);
> 						charray_free(myattrs);
> 					}
> 				}
> 			}
>+			slapi_valueset_free(objclassvals);
> 		}
> 
> 		/* get operational attrs */
> 		opattrs = slapi_schema_list_attribute_names(SLAPI_ATTR_FLAG_OPATTR);
> 
> 		if (isextensibleobj)
> 		{
> 			for ( i = 0; attrs[i]; i++ )
>@@ -701,19 +702,19 @@
> 							_append_gerstr(gerstr, gerstrsize, gerstrcap, ", ", NULL);
> 						}
> 						_append_gerstr(gerstr, gerstrsize, gerstrcap, attrs[i], ":");
> 						_append_gerstr(gerstr, gerstrsize, gerstrcap, "none", NULL);
> 						isfirstattr = 0;
> 					}
> 				}
> 			}
>-			charray_free(allattrs);
>-			charray_free(opattrs);
> 		}
>+		charray_free(allattrs);
>+		charray_free(opattrs);
> 	}
> 	else
> 	{
> 		Slapi_Attr *prevattr = NULL, *attr;
> 		char *type;
> 
> 		while ( slapi_entry_next_attr ( e, prevattr, &attr ) == 0 )
> 		{

Actions: View | Diff

Attachments on bug 457156: 312947 | 313006 | 313120 | 313121 | 313136 | 313137 | 313854 | 313980