Attachment 313856 Details for Bug 458506 – diffs

[patch] diffs

diffs.bug458506 (text/plain), 1.82 KB, created by Rich Megginson on 2008-08-08 23:46:19 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Rich Megginson

Created: 2008-08-08 23:46:19 UTC

Size: 1.82 KB

patch

obsolete

>Index: ldapserver/ldap/servers/slapd/bind.c
>===================================================================
>RCS file: /cvs/dirsec/ldapserver/ldap/servers/slapd/bind.c,v
>retrieving revision 1.12
>diff -u -8 -r1.12 bind.c
>--- ldapserver/ldap/servers/slapd/bind.c	16 May 2008 16:46:49 -0000	1.12
>+++ ldapserver/ldap/servers/slapd/bind.c	8 Aug 2008 23:45:14 -0000
>@@ -184,16 +184,19 @@
>         /* Get the SASL mechanism */
>         rc = ber_scanf( ber, "{a", &saslmech );
>         /* Get the (optional) SASL credentials */
>         if ( rc != LBER_ERROR ) {
>             /* Credentials are optional in SASL bind */
>             ber_len_t clen;
>             if (( ber_peek_tag( ber, &clen )) == LBER_OCTETSTRING ) {
>                 rc = ber_scanf( ber, "o}}", &cred );
>+                if (cred.bv_len == 0) {
>+                    slapi_ch_free_string(&cred.bv_val);
>+                }
>             } else {
>                 rc = ber_scanf( ber, "}}" );
>             }
>         }
>         break;
>     case LDAP_AUTH_KRBV41:
>         /* FALLTHROUGH */
>     case LDAP_AUTH_KRBV42:
>@@ -205,16 +208,19 @@
>             log_bind_access (pb, slapi_sdn_get_dn (&sdn), method, version, saslmech, kmsg);
>             send_ldap_result( pb, LDAP_PROTOCOL_ERROR, NULL,
>                               kmsg, 0, NULL );
>             goto free_and_return;
>         }
>         /* FALLTHROUGH */
>     case LDAP_AUTH_SIMPLE:
>         rc = ber_scanf( ber, "o}", &cred );
>+        if (cred.bv_len == 0) {
>+            slapi_ch_free_string(&cred.bv_val);
>+        }
>         break;
>     default:
>         log_bind_access (pb, slapi_sdn_get_dn (&sdn), method, version, saslmech, "Unknown bind method");
>         send_ldap_result( pb, LDAP_PROTOCOL_ERROR, NULL,
>                           "Unknown bind method", 0, NULL );
>         goto free_and_return;
>     }
>     if ( rc == LBER_ERROR ) {

Actions: View | Diff

Attachments on bug 458506: 313856 | 314144 | 315144